Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1315249
| From | Keith Busch <keith.busch@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] block: fix bio splitting on max sectors |
| Date | 2016-01-22 21:20 +0100 |
| Message-ID | <qTQlA-Ac-1@gated-at.bofh.it> (permalink) |
| References | <qTOMN-7Ux-1@gated-at.bofh.it> <qTOWt-7Yf-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jan 22, 2016 at 10:43:59AM -0800, Linus Torvalds wrote: > On Fri, Jan 22, 2016 at 10:29 AM, Ming Lei <tom.leiming@gmail.com> wrote: > > > > This patch fixes the issue by making the max io size aligned > > to logical block size. > > Looks better, thanks. > > I'd suggest also moving the "max_sectors" variable into the > bio_for_each_segment() loop too just to keep variables with minimal > scope, but at least this is fairly legible. The value of max_sectors doesn't change in this function, so its calculation could be done just once instead of with each segment iteration. Other than that, thanks Ming, the fix looks good to me. Third try's a charm?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] block: fix bio splitting on max sectors Ming Lei <tom.leiming@gmail.com> - 2016-01-22 19:40 +0100
Re: [PATCH] block: fix bio splitting on max sectors Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-22 19:50 +0100
Re: [PATCH] block: fix bio splitting on max sectors Keith Busch <keith.busch@intel.com> - 2016-01-22 21:20 +0100
Re: [PATCH] block: fix bio splitting on max sectors Keith Busch <keith.busch@intel.com> - 2016-01-22 21:40 +0100
Re: [PATCH] block: fix bio splitting on max sectors Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-22 21:40 +0100
csiph-web