Re: [PATCH RFC] mm: Rework virtual memory accounting

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC] mm: Rework virtual memory accounting
Date	2016-01-22 21:40 +0100
Message-ID	<qTQEW-IC-3@gated-at.bofh.it> (permalink)
References	<qKNmV-7GX-1@gated-at.bofh.it> <qKOsF-8lW-3@gated-at.bofh.it> <qTPSy-9C-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 22, 2016 at 11:42 AM, Christian Borntraeger
<borntraeger@de.ibm.com> wrote:
>
> Just want to mention that this patch breaks older versions of valgrind
> (including the current release)
> https://bugs.kde.org/show_bug.cgi?id=357833

Ugh. Looks like valgrind is doing something that fundamentally can't
be "tweaked" around in the algorithm. Setting the data limit to zero
will never work with any model that starts accounting any mmap, so we
can't just tweak things a bit..

> It is fixed in trunk (and even triggered some good cleanups, so the valgrind
> developers do NOT want it to get reverted).

Hmm. If we start getting complaints from users, I suspect we'll just
have to revert. The fact that the valgrind developers are ok with the
change doesn't much matter - all that matters is whether users are ok
with it.

The only saving grace is that valgrind is fairly specialized, so it's
not like it breaks some core workflow. But I could easily see people
who run valgrind as part of some regression suite having their
day-to-day work broken.

So I'll let it slide for now, but if I start seeing complaints, I
think we'll just have to revert and wait for fixed valgrind versions
to actually percolate out to people and re-do it later.. (The
"percolate out to people" tends to take a _loong_ time, though).

                 Linus

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH RFC] mm: Rework virtual memory accounting Christian Borntraeger <borntraeger@de.ibm.com> - 2016-01-22 20:50 +0100
  Re: [PATCH RFC] mm: Rework virtual memory accounting Andrew Morton <akpm@linux-foundation.org> - 2016-01-22 21:30 +0100
  Re: [PATCH RFC] mm: Rework virtual memory accounting Cyrill Gorcunov <gorcunov@gmail.com> - 2016-01-22 21:30 +0100
  Re: [PATCH RFC] mm: Rework virtual memory accounting Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-22 21:40 +0100

csiph-web