Re: [PATCH v3 3/5] firmware: fold successful fw read early

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	"Luis R. Rodriguez" <mcgrof@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 3/5] firmware: fold successful fw read early
Date	Fri, 22 Jan 2016 21:00:03 +0100
Message-ID	<qTQ2f-cO-13@gated-at.bofh.it> (permalink)
References	<qIZix-6pz-3@gated-at.bofh.it> <qIZiy-6pz-25@gated-at.bofh.it> <qNkeK-8sV-5@gated-at.bofh.it> <qTz1n-5gH-1@gated-at.bofh.it> <qTIxH-3xw-5@gated-at.bofh.it>
X-Original-To	Mimi Zohar <zohar@linux.vnet.ibm.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=VvEQiSxpBcSSzrezokTTx6qNPFh1pKSmnNYSqzXhYk8=; b=cMdWYuuQzxR+wMhGcdg8SvGZMkP74ZlV/03Iq6XDCzEy8cmSeKlTTMYSHrEe/gKjrb wuWTeFQEw7CRLXklpOIrGrHTNO1E9ihrrgyEVs4No2qsncCU8JftIyg785YFF/ESWtu/ I+618jwc6OyFDp0DO91N4R11GXXiO454vn95LE+HEe4B8/X1tF4RcNvXTWKfYpJIEF3c 2Agxx2E5BarvrWa3CFqYcjX+p7DCBceJiduGAnj30CaY1l/h92QtjYiIcl8XfSFozJAV 8Mxjrtdgfin340Plhoo/qANOqB+ks1LpYR2JSoHNihzWUYro7wNRgLF1RwCPxDtJeaB4 LQ4Q==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=VvEQiSxpBcSSzrezokTTx6qNPFh1pKSmnNYSqzXhYk8=; b=QTtkRmGXqZsPwvl/fxs+9w0Xa5NvbODjFgzrlDZ8mMTxZjGkV4mFzsRW9y1LXE2tvQ +0w9gGiqrRzYyFl93JZuPRdWxFow2NRuFocm5BOOsWspZwyuvVY6gDKEh01UliqVpvXu Zk/Tv4aJ/C51h0M41PE+Pz8cmHTQUAbO79KKXO57Wb8J+UhIp31mHmNpXysvF4MLMGkK /5bNop6a/lhlxvqZsb7TnmnGonODvRNcb+izSNVnPUK9b+3L08en0GJ/NsFxTaDB0G0s CxJ/VA/b1SdfnzvGwRCsasZ3YQUTM7wivBSuIunxhf34Lkngj3MTa4AzajcaniSROzO1 6jog==
X-Gm-Message-State	AG10YOSR5sVdqY39xpMZ4MMk8EZVgzOSlYZnk6TfdNeUqHBCnuExXYdB0qxlyH/p2CPN9FAHFEEQupTDRyCJzw==
X-Received	by 10.37.57.15 with SMTP id g15mr2480483yba.41.1453492261692; Fri, 22 Jan 2016 11:51:01 -0800 (PST)
MIME-Version	1.0
X-Google-Sender-Auth	2tz9w24hcKJe1DQH2E50QhGgJAo
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	Josh Boyer <jwboyer@fedoraproject.org>, Greg KH <gregkh@linuxfoundation.org>, Ming Lei <ming.lei@canonical.com>, Johannes Berg <johannes@sipsolutions.net>, Andy Lutomirski <luto@amacapital.net>, Jonathan Corbet <corbet@lwn.net>, David Woodhouse <dwmw2@infradead.org>, David Howells <dhowells@redhat.com>, Seth Forshee <seth.forshee@canonical.com>, Rusty Russell <rusty@rustcorp.com.au>, Michal Marek <mmarek@suse.cz>, Matthew Garrett <mjg59@srcf.ucam.org>, Kyle McMartin <kyle@kernel.org>, Dmitry Kasatkin <dmitry.kasatkin@gmail.com>, Vivek Goyal <vgoyal@redhat.com>, Brian Norris <computersforpeace@gmail.com>, Kees Cook <keescook@chromium.org>, shuahkh@osg.samsung.com, Linus Torvalds <torvalds@linux-foundation.org>, linux-security-module <linux-security-module@vger.kernel.org>, keyrings@linux-nfs.org, "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
X-Original-Date	Fri, 22 Jan 2016 11:50:42 -0800
X-Original-Message-ID	<CAB=NE6V5Y1BvAk45mNDCiqrc9dAjsDSLmJ_1fV03uQ=Cz-+JYQ@mail.gmail.com>
X-Original-References	<1450906497-24179-1-git-send-email-mcgrof@do-not-panic.com> <1450906497-24179-4-git-send-email-mcgrof@do-not-panic.com> <CA+5PVA6O_rhHF2d+4iNjwNCQWz7F5-EwJUBjaM4-XdRYDMxXmw@mail.gmail.com> <20160122014541.GV20964@wotan.suse.de> <1453463812.9549.202.camel@linux.vnet.ibm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1315245

Show key headers only | View raw

On Fri, Jan 22, 2016 at 3:56 AM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:
> On Fri, 2016-01-22 at 02:45 +0100, Luis R. Rodriguez wrote:
>> On Mon, Jan 04, 2016 at 03:48:29PM -0500, Josh Boyer wrote:
>> > On Wed, Dec 23, 2015 at 4:34 PM, Luis R. Rodriguez
>> > <mcgrof@do-not-panic.com> wrote:
>> > > From: David Howells <dhowells@redhat.com>
>> > >
>> > > We'll be folding in some more checks on fw_read_file_contents(),
>> > > this will make the success case easier to follow.
>> > >
>> > > Signed-off-by: David Howells <dhowells@redhat.com>
>> > > Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
>> >
>> > Reviewed-by: Josh Boyer <jwboyer@fedoraproject.org>
>>
>> Thanks Josh.
>>
>> Mimi, this is the other patch that  I was referring to.
>
> After this patch set, replacing the fw_read_file calls with the
> kernel_read_file_from_path() version is straight forward.  Nice!

Great, I take it you will pick it up then ? :)

  Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 3/5] firmware: fold successful fw read early "Luis R. Rodriguez" <mcgrof@suse.com> - 2016-01-22 02:50 +0100
  Re: [PATCH v3 3/5] firmware: fold successful fw read early Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-01-22 13:00 +0100
    Re: [PATCH v3 3/5] firmware: fold successful fw read early "Luis R. Rodriguez" <mcgrof@suse.com> - 2016-01-22 21:00 +0100

csiph-web