Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1315189

[RFC PATCH] x86/head_64.S: remove redundant check that kernel address is 2M aligned

From Alexander Kuleshov <kuleshovmail@gmail.com>
Newsgroups linux.kernel
Subject [RFC PATCH] x86/head_64.S: remove redundant check that kernel address is 2M aligned
Date 2016-01-22 19:20 +0100
Message-ID <qTOtr-7NF-13@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


We check that the base address of the kernel is 2M aligned in
the arch/x86/kernel/head_65.S right after jump to the decompressed
kernel. But we already have a check in the decompress_kernel()
which validates that kernel location is MIN_KERNEL_ALIGN aligned
which is 2M too for x86_64.

Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
---
 arch/x86/kernel/head_64.S | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/x86/kernel/head_64.S b/arch/x86/kernel/head_64.S
index ffdc0e8..4967cba 100644
--- a/arch/x86/kernel/head_64.S
+++ b/arch/x86/kernel/head_64.S
@@ -75,12 +75,6 @@ startup_64:
 	leaq	_text(%rip), %rbp
 	subq	$_text - __START_KERNEL_map, %rbp
 
-	/* Is the address not 2M aligned? */
-	movq	%rbp, %rax
-	andl	$~PMD_PAGE_MASK, %eax
-	testl	%eax, %eax
-	jnz	bad_address
-
 	/*
 	 * Is the address too large?
 	 */
-- 
2.7.0.25.gfc10eb5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH] x86/head_64.S: remove redundant check that kernel address is 2M aligned Alexander Kuleshov <kuleshovmail@gmail.com> - 2016-01-22 19:20 +0100
  Re: [RFC PATCH] x86/head_64.S: remove redundant check that kernel  address is 2M aligned Brian Gerst <brgerst@gmail.com> - 2016-01-23 02:50 +0100
    Re: [RFC PATCH] x86/head_64.S: remove redundant check that kernel  address is 2M aligned Alexander Kuleshov <kuleshovmail@gmail.com> - 2016-01-23 07:50 +0100

csiph-web