Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1315182

[PATCH] bus: vexpress-config: Add missing of_node_put

Show all headers | View raw

for_each_compatible_node performs an of_node_get on each iteration, so
to break out of the loop an of_node_put is required.

Found using Coccinelle. The semantic patch used for this is as follows:

// <smpl>
@@
expression e;
local idexpression n;
@@

 for_each_compatible_node(n, ...) {
   ... when != of_node_put(n)
       when != e = n
(
   return n;
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
 drivers/bus/vexpress-config.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
index 6575c0f..c3cb76b 100644
--- a/drivers/bus/vexpress-config.c
+++ b/drivers/bus/vexpress-config.c
@@ -192,8 +192,10 @@ static int __init vexpress_config_init(void)
 	/* Need the config devices early, before the "normal" devices... */
 	for_each_compatible_node(node, NULL, "arm,vexpress,config-bus") {
 		err = vexpress_config_populate(node);
-		if (err)
+		if (err) {
+			of_node_put(node);
 			break;
+		}
 	}
 
 	return err;
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] bus: vexpress-config: Add missing of_node_put Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-01-22 19:10 +0100
  Re: [PATCH] bus: vexpress-config: Add missing of_node_put liviu.dudau@arm.com - 2016-01-25 13:20 +0100
    Re: [PATCH] bus: vexpress-config: Add missing of_node_put Julia Lawall <julia.lawall@lip6.fr> - 2016-01-25 13:30 +0100
      Re: [PATCH] bus: vexpress-config: Add missing of_node_put liviu.dudau@arm.com - 2016-01-25 14:00 +0100

csiph-web