Re: [BUG] Regression introduced with "block: split bios to max possible length"

From	Ming Lei <tom.leiming@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [BUG] Regression introduced with "block: split bios to max possible length"
Date	2016-01-22 18:50 +0100
Message-ID	<qTO0p-7kv-3@gated-at.bofh.it> (permalink)
References	(3 earlier) <qTyyl-55a-1@gated-at.bofh.it> <qTAAa-6tt-7@gated-at.bofh.it> <qTBmz-74w-47@gated-at.bofh.it> <qTLvA-5JF-13@gated-at.bofh.it> <qTNnK-73X-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jan 23, 2016 at 1:03 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Fri, Jan 22, 2016 at 7:06 AM, Ming Lei <tom.leiming@gmail.com> wrote:
>>
>> Yes, it is one problem, something like below does fix my test
>> with 4K block size.
>
> It just doesn't look very legible.

OK, I will try to make it better.

>
> Also, how could this
>
>> -                       goto split;
>> +                       if (sectors)
>> +                               goto split;
>
> ever matter? If sectors is 0, something is seriously wrong afaik.

I guess that is possible because blk_max_size_offset() depends on
offset and may return a small size which is less than logical
block size.

--
Ming Lei

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[BUG] Regression introduced with "block: split bios to max possible  length" Stefan Haberland <sth@linux.vnet.ibm.com> - 2016-01-21 16:00 +0100
  Re: [BUG] Regression introduced with "block: split bios to max  possible length" Jens Axboe <axboe@fb.com> - 2016-01-21 22:40 +0100
    Re: [BUG] Regression introduced with "block: split bios to max  possible length" Keith Busch <keith.busch@intel.com> - 2016-01-22 00:00 +0100
      Re: [BUG] Regression introduced with "block: split bios to max  possible length" Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-22 02:20 +0100
        Re: [BUG] Regression introduced with "block: split bios to max  possible length" Keith Busch <keith.busch@intel.com> - 2016-01-22 04:30 +0100
          Re: [BUG] Regression introduced with "block: split bios to max  possible length" Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-22 05:20 +0100
            Re: [BUG] Regression introduced with "block: split bios to max  possible length" Keith Busch <keith.busch@intel.com> - 2016-01-22 16:00 +0100
              Re: [BUG] Regression introduced with "block: split bios to max  possible length" Jens Axboe <axboe@fb.com> - 2016-01-22 18:20 +0100
            Re: [BUG] Regression introduced with "block: split bios to max  possible length" Ming Lei <tom.leiming@gmail.com> - 2016-01-22 16:10 +0100
              Re: [BUG] Regression introduced with "block: split bios to max  possible length" Linus Torvalds <torvalds@linux-foundation.org> - 2016-01-22 18:10 +0100
                Re: [BUG] Regression introduced with "block: split bios to max  possible length" Ming Lei <tom.leiming@gmail.com> - 2016-01-22 18:50 +0100

csiph-web