Re: [PATCH v2] kernel: add kcov code coverage

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] kernel: add kcov code coverage
Date	2016-01-22 14:00 +0100
Message-ID	<qTJtM-497-9@gated-at.bofh.it> (permalink)
References	(5 earlier) <qSiP0-1Nw-11@gated-at.bofh.it> <qSnYm-5eq-21@gated-at.bofh.it> <qSoro-5DG-13@gated-at.bofh.it> <qTIxI-3xw-17@gated-at.bofh.it> <qTIR5-3TR-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 22, 2016 at 01:15:27PM +0100, Dmitry Vyukov wrote:
> On Fri, Jan 22, 2016 at 12:55 PM, Mark Rutland <mark.rutland@arm.com> wrote:
> > On Mon, Jan 18, 2016 at 09:09:43PM +0100, Dmitry Vyukov wrote:
> >> On Mon, Jan 18, 2016 at 8:44 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
> >> > Regarding KASLR and dynamically loaded modules. I've looked at my
> >> > use-case and concluded
> >> > that most of the time I can work with "non-stable" PCs within a single
> >> > VM. Whenever I need to
> >> > store PCs persistently or send to another machine, I think I can
> >> > "canonicalize" PCs using
> >> > /proc/modules and /proc/kallsyms to something like (module hash,
> >> > module offset). So kernel does
> >> > not need to do this during coverage collection.
> >>
> >> On second though, maybe it's better to just always export unsigned long PCs...
> >> Need to measure how much memory coverage information consumes,
> >> and how much slower it is with uint64 PCs. Maybe I can live with large PCs,
> >> or maybe I can make syzkaller require !KASLR and compress PCs in user-space...
> >> Need to think about this more.
> >
> > I can imagine we might keep the expanded module range even in the
> > absence of full KASLR, though I don't know how realistic that thought
> > is.
> 
> The last version of the patch just exposes PCs as unsigned longs
> without any compression. So it should not be a problem (at least for
> kernel, now it's user responsibility to make sense out of the PCs).

Ah, ok. Sorry for the noise!

Mark.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] kernel: add kcov code coverage Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2016-01-15 14:10 +0100
  Re: [PATCH v2] kernel: add kcov code coverage Will Deacon <will.deacon@arm.com> - 2016-01-15 14:50 +0100
  Re: [PATCH v2] kernel: add kcov code coverage Dmitry Vyukov <dvyukov@google.com> - 2016-01-15 15:10 +0100
    Re: [PATCH v2] kernel: add kcov code coverage Andrey Ryabinin <ryabinin.a.a@gmail.com> - 2016-01-18 14:40 +0100
      Re: [PATCH v2] kernel: add kcov code coverage Dmitry Vyukov <dvyukov@google.com> - 2016-01-18 20:40 +0100
    Re: [PATCH v2] kernel: add kcov code coverage Mark Rutland <mark.rutland@arm.com> - 2016-01-18 15:20 +0100
      Re: [PATCH v2] kernel: add kcov code coverage Dmitry Vyukov <dvyukov@google.com> - 2016-01-18 20:50 +0100
        Re: [PATCH v2] kernel: add kcov code coverage Dmitry Vyukov <dvyukov@google.com> - 2016-01-18 21:20 +0100
          Re: [PATCH v2] kernel: add kcov code coverage Mark Rutland <mark.rutland@arm.com> - 2016-01-22 13:00 +0100
            Re: [PATCH v2] kernel: add kcov code coverage Dmitry Vyukov <dvyukov@google.com> - 2016-01-22 13:20 +0100
              Re: [PATCH v2] kernel: add kcov code coverage Mark Rutland <mark.rutland@arm.com> - 2016-01-22 14:00 +0100

csiph-web