Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131

From	Michał Kępień <kernel@kempniu.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell Vostro V131
Date	2016-01-22 12:10 +0100
Message-ID	<qTHLl-3dT-53@gated-at.bofh.it> (permalink)
References	(4 earlier) <qTjpE-39M-21@gated-at.bofh.it> <qTl85-45V-1@gated-at.bofh.it> <qTnMC-5Vj-1@gated-at.bofh.it> <qToSm-6CC-23@gated-at.bofh.it> <qTpEL-7eF-41@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> For full support we need:
> 
> 1) invoke special SMBIOS call for some machine
> 
> 2) patch dell-wmi.c to do not drop some events for some machines
> 
> Part 2) needs to touch only dell-wmi.c code, this is obvious. But I
> thought that part 1) will be done in dell-laptop.c code where are all
> others SMBIOS calls. Reason is just because dell-wmi.c is doing WMI
> stuff. Do you want to include this is part 1) also to dell-wmi.c file?

Yes, that was my idea.  That SMBIOS call is basically WMI initialization
code.  Consider the case of Vostro V131 - there is no WMI on that
machine without that SMBIOS call and there is no need to issue that
SMBIOS call if you don't want to use WMI.  Given that dell-wmi does not
depend on dell-laptop, consider the extreme case where the user selects
CONFIG_DELL_LAPTOP=n and CONFIG_DELL_WMI=m, expecting WMI to work.  If
we put the WMI-enabling SMBIOS call in dell-laptop, it won't.  Also,
once my Dell SMBIOS API rework series gets applied, adding the relevant
call to dell-wmi will be easy.

-- 
Best regards,
Michał Kępień

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Pali Rohár <pali.rohar@gmail.com> - 2016-01-21 10:10 +0100
  Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2016-01-21 12:00 +0100
    Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Pali Rohár <pali.rohar@gmail.com> - 2016-01-21 14:50 +0100
      Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2016-01-21 16:00 +0100
        Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Pali Rohár <pali.rohar@gmail.com> - 2016-01-21 16:50 +0100
          Re: [PATCH v2] dell-wmi: process Dell Instant Launch hotkey on Dell  Vostro V131 Michał Kępień <kernel@kempniu.pl> - 2016-01-22 12:10 +0100

csiph-web