Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1314849

Re: [PATCH 1/9] perf, tools, stat: Abstract stat metrics printing

Show all headers | View raw

On Tue, Jan 19, 2016 at 06:26:44PM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Abstract the printing of shadow metrics. Instead of every
> metric calling fprintf directly and taking care of indentation,
> use two call backs: one to print metrics and another to
> start a new line.
> 
> This will allow adding metrics to CSV mode and also
> using them for other purposes.
> 
> The computation of padding is now done in the central
> callback, instead of every metric doing it manually.
> This makes it easier to add new metrics.
> 
> v2: Refactor functions, printout now does more. Move
> shadow printing. Improve fallback callbacks. Don't
> use void * callback data.
> v3: Remove unnecessary hunk. Add typedef for new_line
> v4: Remove unnecessary hunk. Don't print metrics for CSV/interval
> mode yet.  Move printout change to separate patch.
> v5: Fix bisect bugs. Avoid bogus frontend cycles printing.
> Fix indentation in different aggregation modes.
> v6: Delay newline handling
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

perf, tools: Refactor and support interval and CSV metrics Andi Kleen <andi@firstfloor.org> - 2016-01-20 03:30 +0100
  [PATCH 7/9] perf, tools, stat: Implement --metric-only mode Andi Kleen <andi@firstfloor.org> - 2016-01-20 03:30 +0100
  [PATCH 9/9] perf, tools, stat: Fix indentation of counter running printout Andi Kleen <andi@firstfloor.org> - 2016-01-20 03:30 +0100
  [PATCH 5/9] perf, tools: Support metrics in --per-core/socket mode Andi Kleen <andi@firstfloor.org> - 2016-01-20 03:40 +0100
  [PATCH 8/9] perf, tools: Add --metric-only support for -A Andi Kleen <andi@firstfloor.org> - 2016-01-20 03:40 +0100
  [PATCH 1/9] perf, tools, stat: Abstract stat metrics printing Andi Kleen <andi@firstfloor.org> - 2016-01-20 03:40 +0100
    Re: [PATCH 1/9] perf, tools, stat: Abstract stat metrics printing Jiri Olsa <jolsa@redhat.com> - 2016-01-22 10:50 +0100
    Re: [PATCH 1/9] perf, tools, stat: Abstract stat metrics printing Jiri Olsa <jolsa@redhat.com> - 2016-01-22 11:10 +0100
  Re: perf, tools: Refactor and support interval and CSV metrics Jiri Olsa <jolsa@redhat.com> - 2016-01-22 11:20 +0100

csiph-web