Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust

From	Pekka Enberg <penberg@iki.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust
Date	2016-01-22 08:20 +0100
Message-ID	<qTEaJ-Fx-5@gated-at.bofh.it> (permalink)
References	<qTgrM-Pf-9@gated-at.bofh.it> <qTwGe-3KM-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/22/2016 01:12 AM, David Rientjes wrote:
> NACK to your patch as it is just covering up buggy code silently. The 
> problem needs to be addressed in change_memory_common() to return if 
> there is no size to change (numpages == 0). It's a two line fix to 
> that function. 

So add a WARN_ON there to *warn* about the situations. There's really no 
need to BUG_ON here.

- Pekka

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH, REGRESSION v3] mm: make apply_to_page_range more robust Mika Penttilä <mika.penttila@nextfour.com> - 2016-01-21 07:00 +0100
  Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more  robust David Rientjes <rientjes@google.com> - 2016-01-22 00:20 +0100
    Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust Mika Penttilä <mika.penttila@nextfour.com> - 2016-01-22 07:20 +0100
    Re: [PATCH, REGRESSION v3] mm: make apply_to_page_range more robust Pekka Enberg <penberg@iki.fi> - 2016-01-22 08:20 +0100

csiph-web