Re: [PATCH 1/2] Staging:lustre:obdclass:linux:remove unnecessary braces

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] Staging:lustre:obdclass:linux:remove unnecessary braces
Date	2016-01-20 20:10 +0100
Message-ID	<qT6iL-2se-33@gated-at.bofh.it> (permalink)
References	<qT5Zn-24v-1@gated-at.bofh.it> <qT5Zn-24v-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2016-01-21 at 00:17 +0530, Bhumika Goyal wrote:
> Fixed 'braces {} are not necessary for single statement blocks'
> checkpatch.pl warning.
[]
> diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c b/drivers/staging/lustre/lustre/obdclass/linux/linux-module.c
[]
> @@ -144,9 +144,8 @@ int obd_ioctl_getdata(char **buf, int *len, void *arg)
>  		offset += cfs_size_round(data->ioc_inllen3);
>  	}
>  
> -	if (data->ioc_inllen4) {
> +	if (data->ioc_inllen4)
>  		data->ioc_inlbuf4 = &data->ioc_bulk[0] + offset;

You might also consider converting uses of &foo[0] to foo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2]Staging:lustre:obdclass:linux:fix checkpatch.pl warnings Bhumika Goyal <bhumirks@gmail.com> - 2016-01-20 19:50 +0100
  [PATCH 2/2] Staging:lustre:obdclass:linux:simplify NULL comparison Bhumika Goyal <bhumirks@gmail.com> - 2016-01-20 19:50 +0100
  [PATCH 1/2] Staging:lustre:obdclass:linux:remove unnecessary braces Bhumika Goyal <bhumirks@gmail.com> - 2016-01-20 19:50 +0100
    Re: [PATCH 1/2] Staging:lustre:obdclass:linux:remove unnecessary  braces Joe Perches <joe@perches.com> - 2016-01-20 20:10 +0100

csiph-web