Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1313386

Re: [PATH v2] NVMe: init nvme queue before enabling irq

Show all headers | View raw

On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote:
> From: Wenbo Wang <wenbo.wang@memblaze.com>
> 
> During reset process, the nvme_dev->bar (ioremapped) may change,
> so nvmeq->q_db shall be also updated by nvme_init_queue().
> 
> Currently nvmeq irq is enabled before queue init, so a spurious
> interrupt triggered nvme_process_cq may access nvmeq->q_db just
> before it is updated, this could cause kernel panic.
> 
> Signed-off-by: Wenbo Wang <wenbo.wang@memblaze.com>
> Reviewed-by: Wenwei Tao <wenwei.tao@memblaze.com>
> ---
>  drivers/nvme/host/pci.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATH v2] NVMe: init nvme queue before enabling irq Wenbo Wang <mail_weber_wang@163.com> - 2016-01-20 11:50 +0100
  Re: [PATH v2] NVMe: init nvme queue before enabling irq Sagi Grimberg <sagig@dev.mellanox.co.il> - 2016-01-20 13:40 +0100
  Re: [PATH v2] NVMe: init nvme queue before enabling irq Keith Busch <keith.busch@intel.com> - 2016-01-20 16:00 +0100
  Re: [PATH v2] NVMe: init nvme queue before enabling irq Johannes Thumshirn <jthumshirn@suse.de> - 2016-01-20 16:20 +0100
  Re: [PATH v2] NVMe: init nvme queue before enabling irq Greg KH <gregkh@linuxfoundation.org> - 2016-01-20 18:20 +0100
    Re: [PATH v2] NVMe: init nvme queue before enabling irq Jens Axboe <axboe@fb.com> - 2016-01-20 18:20 +0100

csiph-web