Re: [PATCH 1/2] staging:iio:adc:added space around '-'

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] staging:iio:adc:added space around '-'
Date	2016-01-20 15:30 +0100
Message-ID	<qT1VM-7Ky-9@gated-at.bofh.it> (permalink)
References	<qRixH-2cl-3@gated-at.bofh.it> <qRixH-2cl-1@gated-at.bofh.it> <qRj0K-2C0-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jan 15, 2016 at 09:15:52PM +0100, Lars-Peter Clausen wrote:
> On 01/15/2016 08:42 PM, Bhumika Goyal wrote:
> > This patch adds apace around '-' operator.Found using checkpatch.pl
> > 
> > Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> > ---
> >  drivers/staging/iio/adc/ad7280a.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> > index f45ebed..0c73bce 100644
> > --- a/drivers/staging/iio/adc/ad7280a.c
> > +++ b/drivers/staging/iio/adc/ad7280a.c
> > @@ -744,14 +744,14 @@ out:
> >  }
> >  
> >  static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
> > -		in_voltage-voltage_thresh_low_value,
> > +		in_voltage - voltage_thresh_low_value,
> 
> Hi,
> 
> Thanks for patch. But when sending cleanup patches like this please make
> sure that you a) understand what the code does and how your change affects
> it and b) as a bare minimum of testing perform a compile test, if possible
> also do functional testing.
> 
> The patch as it is, is neither semantically nor syntactically correct. As an
> exercise please make sure you understand why.

Ugh!

It took me a long time to figure out the bug in this patch...  Why does
that filename have a mix of dashes and underscores?  Too late to fix it
now...  :/

regards,
dan carpenter

Thread

[PATCH 1/2] staging:iio:adc:added space around '-' Bhumika Goyal <bhumirks@gmail.com> - 2016-01-15 20:50 +0100
  Re: [PATCH 1/2] staging:iio:adc:added space around '-' Lars-Peter Clausen <lars@metafoo.de> - 2016-01-15 21:20 +0100
    Re: [PATCH 1/2] staging:iio:adc:added space around '-' Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-20 15:30 +0100
      Re: [PATCH 1/2] staging:iio:adc:added space around '-' Jonathan Cameron <jic23@kernel.org> - 2016-01-24 17:40 +0100
        Re: [PATCH 1/2] staging:iio:adc:added space around '-' Lars-Peter Clausen <lars@metafoo.de> - 2016-01-24 19:00 +0100

csiph-web