Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1313243
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v9 2/6] Documentation, dt, arm64/arm: dt bindings for numa. |
| Date | 2016-01-20 15:20 +0100 |
| Message-ID | <qT1M7-7FE-25@gated-at.bofh.it> (permalink) |
| References | <qSlDc-3Oc-29@gated-at.bofh.it> <qT1M7-7FE-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jan 18, 2016 at 10:06:01PM +0530, Ganapatrao Kulkarni wrote:
> DT bindings for numa mapping of memory, cores and IOs.
>
> Reviewed-by: Robert Richter <rrichter@cavium.com>
> Signed-off-by: Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>
> ---
> Documentation/devicetree/bindings/arm/numa.txt | 272 +++++++++++++++++++++++++
> 1 file changed, 272 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/numa.txt
This is looks okay to me, but some cosmetic things on the example.
> +==============================================================================
> +4 - Example dts
> +==============================================================================
> +
> +2 sockets system consists of 2 boards connected through ccn bus and
> +each board having one socket/soc of 8 cpus, memory and pci bus.
> +
> + memory@00c00000 {
Drop the leading 0s on unit addresses.
> + device_type = "memory";
> + reg = <0x0 0x00c00000 0x0 0x80000000>;
> + /* node 0 */
> + numa-node-id = <0>;
> + };
> +
> + memory@10000000000 {
> + device_type = "memory";
> + reg = <0x100 0x00000000 0x0 0x80000000>;
> + /* node 1 */
> + numa-node-id = <1>;
> + };
> +
> + cpus {
> + #address-cells = <2>;
> + #size-cells = <0>;
> +
> + cpu@000 {
Same here (leaving one of course).
> + device_type = "cpu";
> + compatible = "arm,armv8";
> + reg = <0x0 0x000>;
> + enable-method = "psci";
> + /* node 0 */
> + numa-node-id = <0>;
> + };
> + cpu@001 {
and so on...
> + device_type = "cpu";
> + compatible = "arm,armv8";
> + reg = <0x0 0x001>;
Either all leading 0s or none.
> + reg = <0x0 0x008>;
> + enable-method = "psci";
> + /* node 1 */
Kind of a pointless comment.
Wouldn't each cluster of cpus for a given numa node be in a different
cpu affinity? Certainly not required by the architecture, but the common
case at least.
> + numa-node-id = <1>;
> + };
[...]
> + pcie0: pcie0@0x8480,00000000 {
Drop the 0x and the comma.
> + compatible = "arm,armv8";
> + device_type = "pci";
> + bus-range = <0 255>;
> + #size-cells = <2>;
> + #address-cells = <3>;
> + reg = <0x8480 0x00000000 0 0x10000000>; /* Configuration space */
> + ranges = <0x03000000 0x8010 0x00000000 0x8010 0x00000000 0x70 0x00000000>;
> + /* node 0 */
> + numa-node-id = <0>;
> + };
> +
> + pcie1: pcie1@0x9480,00000000 {
ditto
> + compatible = "arm,armv8";
> + device_type = "pci";
> + bus-range = <0 255>;
> + #size-cells = <2>;
> + #address-cells = <3>;
> + reg = <0x9480 0x00000000 0 0x10000000>; /* Configuration space */
> + ranges = <0x03000000 0x9010 0x00000000 0x9010 0x00000000 0x70 0x00000000>;
> + /* node 1 */
> + numa-node-id = <1>;
> + };
> +
> + distance-map {
> + compatible = "numa-distance-map-v1";
> + distance-matrix = <0 0 10>,
> + <0 1 20>,
> + <1 1 10>;
> + };
> --
> 1.8.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v9 0/6] arm64, numa: Add numa support for arm64 platforms Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com> - 2016-01-18 18:20 +0100
Re: [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware David Daney <ddaney.cavm@gmail.com> - 2016-01-18 18:50 +0100
Re: [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware Ganapatrao Kulkarni <gpkulkarni@gmail.com> - 2016-01-19 07:00 +0100
Re: [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-01-19 10:50 +0100
Re: [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware Ganapatrao Kulkarni <gpkulkarni@gmail.com> - 2016-01-19 13:40 +0100
Re: [PATCH v9 4/6] arm64, dt, thunderx: Add initial dts for Cavium Thunderx in 2 node topology. David Daney <ddaney.cavm@gmail.com> - 2016-01-18 19:00 +0100
Re: [PATCH v9 2/6] Documentation, dt, arm64/arm: dt bindings for numa. Rob Herring <robh@kernel.org> - 2016-01-20 15:20 +0100
Re: [PATCH v9 2/6] Documentation, dt, arm64/arm: dt bindings for numa. Ganapatrao Kulkarni <gpkulkarni@gmail.com> - 2016-01-26 18:20 +0100
Re: [PATCH v9 1/6] arm64, numa: adding numa support for arm64 platforms. Bjorn Helgaas <helgaas@kernel.org> - 2016-01-26 20:00 +0100
Re: [PATCH v9 3/6] arm64/arm, numa, dt: adding numa dt binding implementation for arm64 platforms. Bjorn Helgaas <helgaas@kernel.org> - 2016-01-26 21:40 +0100
Re: [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware Bjorn Helgaas <helgaas@kernel.org> - 2016-01-26 22:00 +0100
Re: [PATCH v9 5/6] PCI: generic: Make pci-host-generic driver numa aware Bjorn Helgaas <helgaas@kernel.org> - 2016-01-26 22:00 +0100
csiph-web