Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1311984
| From | chenfeng <puck.chen@hisilicon.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH RESEND] android: binder: Sanity check at binder ioctl |
| Date | 2016-01-19 09:00 +0100 |
| Message-ID | <qSzmO-4JC-15@gated-at.bofh.it> (permalink) |
| References | <qSvCy-23U-19@gated-at.bofh.it> <qSz3r-4CI-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016/1/19 15:33, Greg KH wrote: > On Tue, Jan 19, 2016 at 11:45:36AM +0800, Chen Feng wrote: >> When a process fork a child process, we should not allow the >> child process use the binder which opened by parent process. >> >> But if the binder-object creater is a thread of one process who exit, >> the other thread can also use this binder-object normally. >> We can distinguish this by the member proc->tsk->mm. >> If the thread exit the tsk->mm will be NULL. >> >> proc->tsk->mm != current->mm && proc->tsk->mm >> >> So only allow the shared mm_struct to use the same binder-object and >> check the existence of mm_struct. >> >> Signed-off-by: Chen Feng <puck.chen@hisilicon.com> >> Signed-off-by: Wei Dong <weidong2@hisilicon.com> >> Signed-off-by: Junmin Zhao <zhaojunmin@huawei.com> >> Reviewed-by: Zhuangluan Su <suzhuangluan@hisilicon.com> >> --- >> drivers/android/binder.c | 2 ++ >> 1 file changed, 2 insertions(+) > > Why resend? What changed from the previous version? > My fault, it's my error commit. mistake the current->mm with current->tsk->mm. The robot-compile finds out this error. > greg k-h > > . >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH RESEND] android: binder: Sanity check at binder ioctl Chen Feng <puck.chen@hisilicon.com> - 2016-01-19 05:00 +0100
Re: [PATCH RESEND] android: binder: Sanity check at binder ioctl Greg KH <gregkh@linuxfoundation.org> - 2016-01-19 08:40 +0100
Re: [PATCH RESEND] android: binder: Sanity check at binder ioctl chenfeng <puck.chen@hisilicon.com> - 2016-01-19 09:00 +0100
Re: [PATCH RESEND] android: binder: Sanity check at binder ioctl Greg KH <gregkh@linuxfoundation.org> - 2016-01-19 09:40 +0100
Re: [PATCH RESEND] android: binder: Sanity check at binder ioctl chenfeng <puck.chen@hisilicon.com> - 2016-01-19 10:00 +0100
csiph-web