Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1311931

[PATCH 2/3] mmc: dw_mmc-rockchip: remove prepare_command hook

Show all headers | View raw

This patch remove prepare_command hook from dw_mmc-rockchip
and use dw_mci_pltfm_prepare_command directly since it seems
it doesn't need any other work to be prepared.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 drivers/mmc/host/dw_mmc-rockchip.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c
index d9c92f3..e6968cd 100644
--- a/drivers/mmc/host/dw_mmc-rockchip.c
+++ b/drivers/mmc/host/dw_mmc-rockchip.c
@@ -26,11 +26,6 @@ struct dw_mci_rockchip_priv_data {
 	int			default_sample_phase;
 };
 
-static void dw_mci_rockchip_prepare_command(struct dw_mci *host, u32 *cmdr)
-{
-	*cmdr |= SDMMC_CMD_USE_HOLD_REG;
-}
-
 static int dw_mci_rk3288_setup_clock(struct dw_mci *host)
 {
 	host->bus_hz /= RK3288_CLKGEN_DIV;
@@ -240,12 +235,12 @@ static int dw_mci_rockchip_init(struct dw_mci *host)
 }
 
 static const struct dw_mci_drv_data rk2928_drv_data = {
-	.prepare_command        = dw_mci_rockchip_prepare_command,
+	.prepare_command        = dw_mci_pltfm_prepare_command,
 	.init			= dw_mci_rockchip_init,
 };
 
 static const struct dw_mci_drv_data rk3288_drv_data = {
-	.prepare_command        = dw_mci_rockchip_prepare_command,
+	.prepare_command        = dw_mci_pltfm_prepare_command,
 	.set_ios		= dw_mci_rk3288_set_ios,
 	.execute_tuning		= dw_mci_rk3288_execute_tuning,
 	.parse_dt		= dw_mci_rk3288_parse_dt,
-- 
2.3.7

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] Convert dw_mci_pltfm_prepare_command into a library call Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-19 04:50 +0100
  [PATCH 2/3] mmc: dw_mmc-rockchip: remove prepare_command hook Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-19 05:00 +0100
  [PATCH 3/3] mmc: dw_mmc-exynos: wrapper prepare_command Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-19 05:00 +0100
  Re: [PATCH 0/3] Convert dw_mci_pltfm_prepare_command into a library  call Jaehoon Chung <jh80.chung@samsung.com> - 2016-01-19 05:10 +0100
  Re: [PATCH 0/3] Convert dw_mci_pltfm_prepare_command into a library  call Jaehoon Chung <jh80.chung@samsung.com> - 2016-01-20 09:30 +0100
    Re: [PATCH 0/3] Convert dw_mci_pltfm_prepare_command into a library  call Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-20 10:30 +0100
    Re: [PATCH 0/3] Convert dw_mci_pltfm_prepare_command into a library  call Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-20 13:40 +0100

csiph-web