Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1311807
| From | Andy Lutomirski <luto@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes |
| Date | 2016-01-18 22:10 +0100 |
| Message-ID | <qSpdL-6bN-9@gated-at.bofh.it> (permalink) |
| References | <qSp47-5SG-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Currently they return -1 on error, which will confuse callers if they try to interpret it as a normal negative error code. Signed-off-by: Andy Lutomirski <luto@kernel.org> --- drivers/firmware/dmi_scan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index 0e08e665f715..451ac04ed18d 100644 --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -144,7 +144,7 @@ static int __init dmi_walk_early(void (*decode)(const struct dmi_header *, buf = dmi_early_remap(dmi_base, orig_dmi_len); if (buf == NULL) - return -1; + return -ENOMEM; dmi_decode_table(buf, decode, NULL); @@ -978,11 +978,11 @@ int dmi_walk(void (*decode)(const struct dmi_header *, void *), u8 *buf; if (!dmi_available) - return -1; + return -ENOENT; buf = dmi_remap(dmi_base, dmi_len); if (buf == NULL) - return -1; + return -ENOMEM; dmi_decode_table(buf, decode, private_data); -- 2.5.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/3] dell-wmi: DMI misuse fixes Andy Lutomirski <luto@kernel.org> - 2016-01-18 22:00 +0100
[PATCH v2 2/3] dell-wmi: Fix hotkey table size check Andy Lutomirski <luto@kernel.org> - 2016-01-18 22:10 +0100
Re: [PATCH v2 2/3] dell-wmi: Fix hotkey table size check Jean Delvare <jdelvare@suse.de> - 2016-01-19 09:40 +0100
Re: [PATCH v2 2/3] dell-wmi: Fix hotkey table size check Andy Lutomirski <luto@amacapital.net> - 2016-01-19 19:50 +0100
[PATCH v2 1/3] dell-wmi: Stop storing pointers to DMI tables Andy Lutomirski <luto@kernel.org> - 2016-01-18 22:10 +0100
Re: [PATCH v2 1/3] dell-wmi: Stop storing pointers to DMI tables Jean Delvare <jdelvare@suse.de> - 2016-01-19 09:50 +0100
Re: [PATCH v2 1/3] dell-wmi: Stop storing pointers to DMI tables Jean Delvare <jdelvare@suse.de> - 2016-01-19 12:10 +0100
Re: [PATCH v2 1/3] dell-wmi: Stop storing pointers to DMI tables Andy Lutomirski <luto@amacapital.net> - 2016-01-19 19:30 +0100
[PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes Andy Lutomirski <luto@kernel.org> - 2016-01-18 22:10 +0100
Re: [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes Jean Delvare <jdelvare@suse.de> - 2016-01-19 09:00 +0100
Re: [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes Pali Rohár <pali.rohar@gmail.com> - 2016-01-19 09:40 +0100
Re: [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes Pali Rohár <pali.rohar@gmail.com> - 2016-01-19 10:10 +0100
Re: [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes Jean Delvare <jdelvare@suse.de> - 2016-01-19 10:50 +0100
Re: [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes Andy Lutomirski <luto@amacapital.net> - 2016-01-20 01:00 +0100
Re: [PATCH v2 3/3] dmi: Make dmi_walk and dmi_walk_early return real error codes Jean Delvare <jdelvare@suse.de> - 2016-01-19 10:10 +0100
csiph-web