Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1311804

[PATCH] mm: avoid uninitialized variable in tracepoint

Show all headers | View raw

A newly added tracepoint in the hugepage code uses a variable in the
error handling that is not initialized at that point:

include/trace/events/huge_memory.h:81:230: error: 'isolated' may be used uninitialized in this function [-Werror=maybe-uninitialized]

The result is relatively harmless, as the trace data will in rare
cases contain incorrect data.

This works around the problem by adding an explicit initialization.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7d2eba0557c1 ("mm: add tracepoint for scanning pages")

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index b2db98136af9..bb3b763b1829 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -2320,7 +2320,7 @@ static void collapse_huge_page(struct mm_struct *mm,
 	pgtable_t pgtable;
 	struct page *new_page;
 	spinlock_t *pmd_ptl, *pte_ptl;
-	int isolated, result = 0;
+	int isolated = 0, result = 0;
 	unsigned long hstart, hend;
 	struct mem_cgroup *memcg;
 	unsigned long mmun_start;	/* For mmu_notifiers */

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: avoid uninitialized variable in tracepoint Arnd Bergmann <arnd@arndb.de> - 2016-01-18 22:00 +0100
  Re: [PATCH] mm: avoid uninitialized variable in tracepoint Ebru Akagunduz <ebru.akagunduz@gmail.com> - 2016-01-18 23:20 +0100
  Re: [PATCH] mm: avoid uninitialized variable in tracepoint "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-01-19 00:10 +0100
    Re: [PATCH] mm: avoid uninitialized variable in tracepoint David Rientjes <rientjes@google.com> - 2016-01-19 23:20 +0100

csiph-web