Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1311721
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 3/4] Input: rotary_encoder - use input_set_capability() |
| Date | 2016-01-18 18:50 +0100 |
| Message-ID | <qSm6g-3ZZ-49@gated-at.bofh.it> (permalink) |
| References | <qSm6e-3ZZ-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Instead of manipulating capability bits directly let's use appropriate
helpers. Also there is no need to explicitly set EV_ABS when calling
input_set_abs_params().
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/rotary_encoder.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/input/misc/rotary_encoder.c b/drivers/input/misc/rotary_encoder.c
index e913bfb64..1882e65 100644
--- a/drivers/input/misc/rotary_encoder.c
+++ b/drivers/input/misc/rotary_encoder.c
@@ -318,14 +318,10 @@ static int rotary_encoder_probe(struct platform_device *pdev)
input->id.bustype = BUS_HOST;
input->dev.parent = dev;
- if (pdata->relative_axis) {
- input->evbit[0] = BIT_MASK(EV_REL);
- input->relbit[0] = BIT_MASK(pdata->axis);
- } else {
- input->evbit[0] = BIT_MASK(EV_ABS);
- input_set_abs_params(encoder->input,
- pdata->axis, 0, pdata->steps, 0, 1);
- }
+ if (pdata->relative_axis)
+ input_set_capability(input, EV_REL, pdata->axis);
+ else
+ input_set_abs_params(input, pdata->axis, 0, pdata->steps, 0, 1);
switch (pdata->steps_per_period) {
case 4:
--
2.6.0.rc2.230.g3dd15c0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] rotary-encoder: use generic device properties Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-18 18:50 +0100 [PATCH 3/4] Input: rotary_encoder - use input_set_capability() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-18 18:50 +0100 [PATCH 2/4] Input: rotary_encoder - convert to use gpiod API Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-18 18:50 +0100 [PATCH 1/4] Input: rotary_encoder - mark PM methods as __maybe_unused Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-18 18:50 +0100 Re: [PATCH 0/4] rotary-encoder: use generic device properties Robert Jarzmik <robert.jarzmik@free.fr> - 2016-01-23 19:10 +0100
csiph-web