Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1311615

Re: lib: sw842: select crc32

Show all headers | View raw

On Wed, Jan 13, 2016 at 11:24:02PM +0100, Arnd Bergmann wrote:
> The sw842 library code was merged in linux-4.1 and causes a very rare randconfig
> failure when CONFIG_CRC32 is not set:
>     
>     lib/built-in.o: In function `sw842_compress':
>     oid_registry.c:(.text+0x12ddc): undefined reference to `crc32_be'
>     lib/built-in.o: In function `sw842_decompress':
>     oid_registry.c:(.text+0x137e4): undefined reference to `crc32_be'
> 
> This adds an explict 'select CRC32' statement, similar to what the other users
> of the crc32 code have. In practice, CRC32 is always enabled anyway because
> over 100 other symbols select it.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 2da572c959dd ("lib: add software 842 compression/decompression")

Patch applied.  Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: lib: sw842: select crc32 Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-18 16:30 +0100

csiph-web