Re: [PATCH 1/2] sched / idle: Drop default_idle_call() fallback from call_cpuidle()

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] sched / idle: Drop default_idle_call() fallback from call_cpuidle()
Date	2016-01-18 15:40 +0100
Message-ID	<qSj8l-1Wu-15@gated-at.bofh.it> (permalink)
References	<qRmrE-4Gw-17@gated-at.bofh.it> <qRmrE-4Gw-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Jan 16, 2016 at 12:54:53AM +0100, Rafael J. Wysocki wrote:
> This eliminates one branch from the idle loop and makes the governors
> and find_deepest_state() handle the case when all states have been
> disabled from sysfs consistently.

> Index: linux-pm/kernel/sched/idle.c
> ===================================================================
> --- linux-pm.orig/kernel/sched/idle.c
> +++ linux-pm/kernel/sched/idle.c
> @@ -97,12 +97,6 @@ void default_idle_call(void)
>  static int call_cpuidle(struct cpuidle_driver *drv, struct cpuidle_device *dev,
>  		      int next_state)
>  {
> -	/* Fall back to the default arch idle method on errors. */
> -	if (next_state < 0) {
> -		default_idle_call();
> -		return next_state;
> -	}
> -
>  	/*
>  	 * The idle task must be scheduled, it is pointless to go to idle, just
>  	 * update no idle residency and return.


Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] sched / idle: Drop default_idle_call() fallback from call_cpuidle() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-16 01:00 +0100
  Re: [PATCH 1/2] sched / idle: Drop default_idle_call() fallback from  call_cpuidle() Peter Zijlstra <peterz@infradead.org> - 2016-01-18 15:40 +0100

csiph-web