Re: [PATCH v4] serial: 8250: add gpio support to exar

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] serial: 8250: add gpio support to exar
Date	2016-01-18 15:10 +0100
Message-ID	<qSiFk-1J1-15@gated-at.bofh.it> (permalink)
References	<qSgWR-uP-13@gated-at.bofh.it> <qSich-1gC-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 18, 2016 at 03:39:01PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 18, 2016 at 2:10 PM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
> > can be controlled using gpio interface.
> > Add support to use these pins.
> 
> Looks better, but…
> 
> >  drivers/gpio/Kconfig                |   7 ++
> >  drivers/gpio/Makefile               |   1 +
> 
> Why is it here?
> 
> >  drivers/tty/serial/8250/8250_gpio.c | 243 ++++++++++++++++++++++++++++++++++++

OOPS... I am sorry, I have made a complete mess of this patch. :(
This was supposed to have drivers/gpio/gpio-exar.c and
not drivers/tty/serial/8250/8250_gpio.c
The entire gpio related code was moved to drivers/gpio/gpio-exar.c and
8250_pci.c was only adding the platform device.
I will post the correct patch tomorrow.
Sorry again.

regards
sudip

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-18 13:20 +0100
  Re: [PATCH v4] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-18 14:40 +0100
    Re: [PATCH v4] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-01-18 15:10 +0100

csiph-web