Re: [PATCH] ALSA: pcm: Fix snd_pcm_hw_params struct copy in compat mode

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Takashi Iwai <tiwai@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ALSA: pcm: Fix snd_pcm_hw_params struct copy in compat mode
Date	Mon, 18 Jan 2016 14:20:02 +0100
Message-ID	<qShSW-179-21@gated-at.bofh.it> (permalink)
References	<qS8Zk-3pH-11@gated-at.bofh.it> <qSbDQ-5ho-13@gated-at.bofh.it> <qShJf-13I-7@gated-at.bofh.it>
User-Agent	Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version	1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	alsa-devel@alsa-project.org, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Jaroslav Kysela <perex@perex.cz>, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 18 Jan 2016 14:18:53 +0100
X-Original-Message-ID	<s5h1t9fuite.wl-tiwai@suse.de>
X-Original-References	<1453088958-6214-1-git-send-email-drinkcat@chromium.org> <s5ha8o3s89j.wl-tiwai@suse.de> <CANMq1KC_EFc0p=2T-sVnFviPkAcW8qNuOoH-unwNjsRygGeu8Q@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1311539

Show key headers only | View raw

On Mon, 18 Jan 2016 14:00:19 +0100,
Nicolas Boichat wrote:
> 
> On Mon, Jan 18, 2016 at 2:37 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > On Mon, 18 Jan 2016 04:49:18 +0100,
> > Nicolas Boichat wrote:
> >>
> >> Running a kernel with KASan enabled, we spotted that the following
> >> read in sound/soc/soc-pcm.c:soc_pcm_hw_params() is out of bounds:
> >>
> >>               /* copy params for each codec */
> >>               codec_params = *params;
> >>
> >> The problem comes from sound/core/pcm_compat.c,
> >> snd_pcm_ioctl_hw_params_compat, where we're copying from a
> >> struct snd_pcm_hw_params to a struct snd_pcm_hw_params32:
> >>
> >>       /* only fifo_size is different, so just copy all */
> >>       data = memdup_user(data32, sizeof(*data32));
> >>
> >> It turns out that snd_pcm_hw_params is 4 bytes longer than
> >> snd_pcm_hw_params32, that's why an out-of-bounds read happens.
> >>
> >> We separate kmalloc and memory copy operations to make sure
> >> data has the correct length.
> >>
> >> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
> >
> > Thanks for reporting.  This is indeed effectively a revert of the
> > commit ef44a1ec6eee ('ALSA: sound/core: use memdup_user()'), which is
> > obviously wrong.  Sigh, it's a really danger of such a "cleanup"
> > patch.
> 
> Oh, well spotted!
> 
> > Could you rephrase the changelog mentioning the affecting commit and
> > resubmit?
> 
> Sure. Looking at that commit, there is another suspicious memdup_user
> in sound/seq/seq_compat.c (similar issue: struct snd_seq_port_info32
> is 4 bytes shorter than struct snd_seq_port_info). I'll revert that
> one as well.

Good catch.  I'm looking forward to seeing newer patches!


Takashi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ALSA: pcm: Fix snd_pcm_hw_params struct copy in compat mode Nicolas Boichat <drinkcat@chromium.org> - 2016-01-18 04:50 +0100
  Re: [PATCH] ALSA: pcm: Fix snd_pcm_hw_params struct copy in compat mode Takashi Iwai <tiwai@suse.de> - 2016-01-18 07:40 +0100
    Re: [PATCH] ALSA: pcm: Fix snd_pcm_hw_params struct copy in compat mode Nicolas Boichat <drinkcat@chromium.org> - 2016-01-18 14:10 +0100
      Re: [PATCH] ALSA: pcm: Fix snd_pcm_hw_params struct copy in compat mode Takashi Iwai <tiwai@suse.de> - 2016-01-18 14:20 +0100

csiph-web