Re: sound: BUG in snd_ctl_find_numid

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Takashi Iwai <tiwai@suse.de>
Newsgroups	linux.kernel
Subject	Re: sound: BUG in snd_ctl_find_numid
Date	Mon, 18 Jan 2016 14:20:02 +0100
Message-ID	<qShSW-179-11@gated-at.bofh.it> (permalink)
References	<qShJg-13I-21@gated-at.bofh.it>
X-Original-To	"Dmitry Vyukov" <dvyukov@google.com>
User-Agent	Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version	1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	49
Organization	linux.* mail to news gateway
X-Original-Cc	<alsa-devel@alsa-project.org>, "Jaroslav Kysela" <perex@perex.cz>, "Takashi Sakamoto" <o-takashi@sakamocchi.jp>, "LKML" <linux-kernel@vger.kernel.org>, "Alexander Potapenko" <glider@google.com>, "Kostya Serebryany" <kcc@google.com>, "syzkaller" <syzkaller@googlegroups.com>, "Sasha Levin" <sasha.levin@oracle.com>
X-Original-Date	Mon, 18 Jan 2016 14:17:27 +0100
X-Original-Message-ID	<s5h37tvuivs.wl-tiwai@suse.de>
X-Original-References	<CACT4Y+bWU+e8zVaMfCee9+6F4J_3Z_9bhNJwz5Rp559CBtMPsw@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1311536

Show key headers only | View raw

On Mon, 18 Jan 2016 13:59:49 +0100,
Dmitry Vyukov wrote:
> 
> Hello,
> 
> The following program triggers a BUG in snd_ctl_find_numid:

Do I understand correctly that you meant a kernel WARNING with a stack
trace as a "BUG"?  If so, the patch below should cover it.


thanks,

Takashi

-- 8< --
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] ALSA: control: Avoid kernel warnings from tlv ioctl with
 numid 0

When a TLV ioctl with numid zero is handled, the driver may spew a
kernel warning with a stack trace at each call.  The check was
intended obviously only for a kernel driver, but not for a user
interaction.  Let's fix it.

This was spotted by syzkaller fuzzer.

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/core/control.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/core/control.c b/sound/core/control.c
index 196a6fe100ca..a85d45595d02 100644
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -1405,6 +1405,8 @@ static int snd_ctl_tlv_ioctl(struct snd_ctl_file *file,
 		return -EFAULT;
 	if (tlv.length < sizeof(unsigned int) * 2)
 		return -EINVAL;
+	if (!tlv.numid)
+		return -EINVAL;
 	down_read(&card->controls_rwsem);
 	kctl = snd_ctl_find_numid(card, tlv.numid);
 	if (kctl == NULL) {
-- 
2.7.0

Thread

sound: BUG in snd_ctl_find_numid Dmitry Vyukov <dvyukov@google.com> - 2016-01-18 14:10 +0100
  Re: sound: BUG in snd_ctl_find_numid Takashi Iwai <tiwai@suse.de> - 2016-01-18 14:20 +0100
    Re: sound: BUG in snd_ctl_find_numid Dmitry Vyukov <dvyukov@google.com> - 2016-01-18 14:20 +0100

csiph-web