Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1313164

[PATCH 3/4] perf stat: Do not clean event's private stats

Show all headers | View raw

Mel reported stddev reporting was broken due to
following commit:
  106a94a0f8c2 perf stat: Introduce read_counters function

This commit merged interval and overall counters
reading into single read_counters function.

The old interval code cleaned the stddev data for
some reason (it's never displayed in interval mode)
and the mentioned commit kept on cleaning the stddev
data in merged function, which resulted in the stddev
not being displayed.

Removing the wrong stddev data cleanup init_stats call.

Reported-by: Mel Gorman <mgorman@techsingularity.net>
Tested-by: Mel Gorman <mgorman@techsingularity.net>
Cc: stable@vger.kernel.org # v4.2+
Cc: Mel Gorman <mgorman@techsingularity.net>
Link: http://lkml.kernel.org/n/tip-tbcxtpjsqrrbwn2me0je8yxt@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/perf/util/stat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
index 2f901d15e063..2b58edccd56f 100644
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@ -310,7 +310,6 @@ int perf_stat_process_counter(struct perf_stat_config *config,
 	int i, ret;
 
 	aggr->val = aggr->ena = aggr->run = 0;
-	init_stats(ps->res_stats);
 
 	if (counter->per_pkg)
 		zero_per_pkg(counter);
-- 
2.4.3

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] perf tools: Fixes Jiri Olsa <jolsa@kernel.org> - 2016-01-20 13:00 +0100
  [PATCH 4/4] perf stat: Making several helper functions static Jiri Olsa <jolsa@kernel.org> - 2016-01-20 13:00 +0100
  [PATCH 2/4] perf tools: Fix HISTC_MEM_DCACHELINE width setting Jiri Olsa <jolsa@kernel.org> - 2016-01-20 13:00 +0100
  [PATCH 1/4] perf tools: Do not read symbols/data from device files Jiri Olsa <jolsa@kernel.org> - 2016-01-20 13:00 +0100
  [PATCH 3/4] perf stat: Do not clean event's private stats Jiri Olsa <jolsa@kernel.org> - 2016-01-20 13:00 +0100

csiph-web