Re: [PATCH] NVMe: init nvme queue before enabling irq

From	Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] NVMe: init nvme queue before enabling irq
Date	2016-01-20 11:30 +0100
Message-ID	<qSYbx-51L-29@gated-at.bofh.it> (permalink)
References	<qST2b-1sB-41@gated-at.bofh.it> <qSX5N-4m2-31@gated-at.bofh.it> <qSXIv-4Bq-11@gated-at.bofh.it> <qSXIv-4Bq-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 20, 2016 at 11:56:01AM +0200, Sagi Grimberg wrote:
> 
> >>If it can cause a kernel panic shouldn't it go through stable then as well?
> >
> >Sorry, not quite understand this comment.
> >The "reset process" is the nvme device reset process (performed by nvme_reset_work()) triggered by device fail condition.
> >During normal boot up, nvmeq door bell is initialized in nvme_alloc_queue() which happens before enabling irq, so there is no error.
> >During nvme device reset process, nvme_alloc_queue() is skipped and the race condition exists.
> 
> I think what Johannes meant was that this patch should include a
> "CC: stable@vger.kernel.org" tag.
> 

Exactly. This makes work for us distribution people a lot easier (i.e. we do
not have to manually scan all commits and decide if we need to backport a
patch or not)

Thanks

> _______________________________________________
> Linux-nvme mailing list
> Linux-nvme@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-nvme

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] NVMe: init nvme queue before enabling irq Wenbo Wang <mail_weber_wang@163.com> - 2016-01-20 06:00 +0100
  Re: [PATCH] NVMe: init nvme queue before enabling irq Sagi Grimberg <sagig@dev.mellanox.co.il> - 2016-01-20 10:10 +0100
  Re: [PATCH] NVMe: init nvme queue before enabling irq Johannes Thumshirn <jthumshirn@suse.de> - 2016-01-20 10:20 +0100
    Re: [PATCH] NVMe: init nvme queue before enabling irq Sagi Grimberg <sagig@dev.mellanox.co.il> - 2016-01-20 11:00 +0100
      Re: [PATCH] NVMe: init nvme queue before enabling irq Johannes Thumshirn <jthumshirn@suse.de> - 2016-01-20 11:30 +0100

csiph-web