Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1312903

RE: [LINUX PATCH 4/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI.

Show all headers | View raw

Hi,

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Tuesday, January 19, 2016 10:46 PM
> To: Lakshmi Sai Krishna Potthuri
> Cc: Michal Simek; Soren Brinkmann; Ulf Hansson; Kevin Hao; Emil P. Lenchak;
> Tobias Klauser; Sudeep Holla; Adrian Hunter; Jisheng Zhang; Ivan T. Ivanov;
> Scott Branden; Vincent Yang; Haibo Chen; Marek Vasut;
> ludovic.desroches@atmel.com; Pawel Moll; Mark Rutland; Ian Campbell;
> Kumar Gala; Suman Tripathi; Shawn Lin; devicetree@vger.kernel.org; Harini
> Katakam; linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org;
> Lakshmi Sai Krishna Potthuri; Anirudha Sarangi; Punnaiah Choudary Kalluri;
> linux-arm-kernel@lists.infradead.org
> Subject: Re: [LINUX PATCH 4/5] Documentation: mmc: Updated the binding
> doc for Arasan SDHCI.
>
> On Tue, Jan 19, 2016 at 07:47:34PM +0530, P L Sai Krishna wrote:
> > This patch adds broken-mmc-highspeed property to the binding doc for
> > Arasan SDHCI.
> >
> > Signed-off-by: P L Sai Krishna <lakshmis@xilinx.com>
> > ---
<snip>
> > -
> > +  - broken-mmc-highspeed: Indicates to force
> > +                           the controller to use in standard speed.
>
> We already have the inverse of this with "cap-mmc-highspeed".
>
> The only potential problem is it will need to be added to existing DTs if you
> start disabling high speed by default. Maybe that's not an issue for users of
> the Arasan driver.
>

It might be an issue for other users.
I know that it will be an issue for older Xilinx SoC (Zynq), for ex.

> Otherwise, you should determine this with a more specific compatible string.
>

Since this feature might be broken on any SoC, I thought it would be
good to provide a dt property.
Using a compatibility string will offer no flexibility as per board or silicon.

Regards,
Harini


This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[LINUX PATCH 1/5] mmc: Workaround for the issue in auto tuning mode. P L Sai Krishna <lakshmi.sai.krishna.potthuri@xilinx.com> - 2016-01-19 15:50 +0100
  [LINUX PATCH 5/5] mmc: host: Update the quirks for this controller. P L Sai Krishna <lakshmi.sai.krishna.potthuri@xilinx.com> - 2016-01-19 15:50 +0100
    Re: [LINUX PATCH 5/5] mmc: host: Update the quirks for this controller. Holger Schurig <holgerschurig@gmail.com> - 2016-01-19 17:10 +0100
  [LINUX PATCH 4/5] Documentation: mmc: Updated the binding doc for Arasan SDHCI. P L Sai Krishna <lakshmi.sai.krishna.potthuri@xilinx.com> - 2016-01-19 15:50 +0100
    Re: [LINUX PATCH 4/5] Documentation: mmc: Updated the binding doc  for Arasan SDHCI. Rob Herring <robh@kernel.org> - 2016-01-19 18:20 +0100
      RE: [LINUX PATCH 4/5] Documentation: mmc: Updated the binding doc  for Arasan SDHCI. Lakshmi Sai Krishna Potthuri   <lakshmi.sai.krishna.potthuri@xilinx.com> - 2016-01-20 07:00 +0100
        Re: [LINUX PATCH 4/5] Documentation: mmc: Updated the binding doc for  Arasan SDHCI. Rob Herring <robh@kernel.org> - 2016-01-20 16:10 +0100
  Re: [LINUX PATCH 1/5] mmc: Workaround for the issue in auto tuning mode. Chen-Yu Tsai <wens@csie.org> - 2016-01-19 16:10 +0100
    RE: [LINUX PATCH 1/5] mmc: Workaround for the issue in auto tuning  mode. Lakshmi Sai Krishna Potthuri   <lakshmi.sai.krishna.potthuri@xilinx.com> - 2016-01-20 06:30 +0100
  Re: [LINUX PATCH 1/5] mmc: Workaround for the issue in auto tuning  mode. Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-01-19 19:00 +0100
    RE: [LINUX PATCH 1/5] mmc: Workaround for the issue in auto tuning  mode. Lakshmi Sai Krishna Potthuri   <lakshmi.sai.krishna.potthuri@xilinx.com> - 2016-01-20 07:10 +0100

csiph-web