Re: [lkp] [mm] 7d2eba0557: BUG: unable to handle kernel NULL pointer dereference at (null)

From	Vlastimil Babka <vbabka@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [lkp] [mm] 7d2eba0557: BUG: unable to handle kernel NULL pointer dereference at (null)
Date	2016-01-20 00:10 +0100
Message-ID	<qSNzs-68i-11@gated-at.bofh.it> (permalink)
References	<qSzwu-52W-5@gated-at.bofh.it> <qSzwu-52W-3@gated-at.bofh.it> <qSN6p-5HE-5@gated-at.bofh.it> <qSNg5-5Mk-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/19/2016 11:45 PM, Cyrill Gorcunov wrote:
> On Tue, Jan 19, 2016 at 02:30:45PM -0800, David Rientjes wrote:
>> On Tue, 19 Jan 2016, Cyrill Gorcunov wrote:
>> 
>> > Seems it should be something like that (untested at moment, please
>> > take a look).
>> > ---
>> > From: Cyrill Gorcunov <gorcunov@openvz.org>
>> > Subject: [PATCH] mm: Fix tracepoint for scanning pages
>> > 
>> > The page might be NULL so use page_to_pfn in conditional call.
>> > 
>> > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
>> 
>> I think this is obviously correct, so
>> 
>> Acked-by: David Rientjes <rientjes@google.com>
> 
> Thank you. I've compile tested it, but didn't run.

This has been in mmotm since november:
http://ozlabs.org/~akpm/mmotm/broken-out/mm-fix-kernel-crash-in-khugepaged-thread.patch

Although your patch does use -1UL instead of -1 (AFAICS the only difference, but
it's too late here), which Steven Rostedt suggested, so it's probably better.

Thread

Re: [lkp] [mm] 7d2eba0557: BUG: unable to handle kernel NULL pointer  dereference at           (null) Cyrill Gorcunov <gorcunov@gmail.com> - 2016-01-19 09:10 +0100
  Re: [lkp] [mm] 7d2eba0557: BUG: unable to handle kernel NULL pointer  dereference at           (null) David Rientjes <rientjes@google.com> - 2016-01-19 23:40 +0100
    Re: [lkp] [mm] 7d2eba0557: BUG: unable to handle kernel NULL pointer  dereference at           (null) Cyrill Gorcunov <gorcunov@gmail.com> - 2016-01-19 23:50 +0100
      Re: [lkp] [mm] 7d2eba0557: BUG: unable to handle kernel NULL pointer  dereference at (null) Vlastimil Babka <vbabka@suse.cz> - 2016-01-20 00:10 +0100
        Re: [lkp] [mm] 7d2eba0557: BUG: unable to handle kernel NULL pointer  dereference at (null) Cyrill Gorcunov <gorcunov@gmail.com> - 2016-01-20 08:30 +0100

csiph-web