[PATCH v2] perf tools: handle spaces in file names obtained from /proc/pid/maps

From	Marcin Ślusarz <marcin.slusarz@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH v2] perf tools: handle spaces in file names obtained from /proc/pid/maps
Date	2016-01-19 20:10 +0100
Message-ID	<qSJPc-3EO-7@gated-at.bofh.it> (permalink)
References	<qLYgh-4AE-5@gated-at.bofh.it> <qN28a-4OO-13@gated-at.bofh.it> <qOs0x-6yc-11@gated-at.bofh.it> <qOYjM-3Du-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Steam frequently puts game binaries in folders with spaces.

Note: "(deleted)" markers are now treated as part of the file name.

It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c
("perf tools: Use sscanf for parsing /proc/pid/maps").

Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 8b10621..956187b 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -274,7 +274,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
 		strcpy(execname, "");
 
 		/* 00400000-0040c000 r-xp 00000000 fd:01 41038  /bin/cat */
-		n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n",
+		n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]\n",
 		       &event->mmap2.start, &event->mmap2.len, prot,
 		       &event->mmap2.pgoff, &event->mmap2.maj,
 		       &event->mmap2.min,
-- 
2.1.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2] perf tools: handle spaces in file names obtained from  /proc/pid/maps Marcin Ślusarz <marcin.slusarz@gmail.com> - 2016-01-19 20:10 +0100

csiph-web