Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1312411

Re: 2015 kernel CVEs

From Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups linux.kernel
Subject Re: 2015 kernel CVEs
Date 2016-01-19 19:10 +0100
Message-ID <qSIT7-33H-1@gated-at.bofh.it> (permalink)
References <qSEFQ-4S-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jan 19, 2016 at 02:28:12PM +0300, Dan Carpenter wrote:
> CVE-2015-4178 820f9f147dcc: fs_pin: uninitialized data

Why is that a CVE?  Affected code is in pin_remove(), which is only
called from fs_pin ->kill() instances; if one is _ever_ called more
than once per fs_pin lifetime, we are already FUBAR.  If Eric had
ever intended to add checks for hlist_unhashed() on those lists,
such checks never had been added to the tree.  They definitely did not
exist at the moment when that commit went in.

It got merged mostly on the "it doesn't harm anything and it's a bit
more tidy that way" basis; if it had ever changed behaviour in any visible
way, *THEN* we had a real problem and that problem was not fixed by that
commit, so I would really like to see the details - simply to make sure
that the damn thing had been eventually fixed.

Eric, could you explain?  And could whoever'd been responsible for
that CVE describe the process that had lead to its creation?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

2015 kernel CVEs Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-19 14:40 +0100
  Re: 2015 kernel CVEs One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-01-19 16:00 +0100
  Re: [kernel-hardening] 2015 kernel CVEs Ben Hutchings <ben@decadent.org.uk> - 2016-01-19 17:40 +0100
    Re: [kernel-hardening] 2015 kernel CVEs Greg KH <greg@kroah.com> - 2016-01-19 19:00 +0100
      Re: [kernel-hardening] 2015 kernel CVEs Ben Hutchings <ben@decadent.org.uk> - 2016-01-20 18:10 +0100
        Re: [kernel-hardening] 2015 kernel CVEs Greg KH <greg@kroah.com> - 2016-01-20 19:10 +0100
          Re: [kernel-hardening] 2015 kernel CVEs Jiri Kosina <jikos@kernel.org> - 2016-01-21 17:10 +0100
          Re: [kernel-hardening] 2015 kernel CVEs Ben Hutchings <ben@decadent.org.uk> - 2016-01-21 19:50 +0100
  Re: 2015 kernel CVEs Peter Hurley <peter@hurleysoftware.com> - 2016-01-19 18:00 +0100
    Re: 2015 kernel CVEs Josh Boyer <jwboyer@fedoraproject.org> - 2016-01-19 18:10 +0100
      Re: 2015 kernel CVEs Greg KH <gregkh@linuxfoundation.org> - 2016-01-19 19:00 +0100
        Re: [kernel-hardening] Re: 2015 kernel CVEs Marcus Meissner <meissner@suse.de> - 2016-01-20 08:20 +0100
  Re: 2015 kernel CVEs Al Viro <viro@ZenIV.linux.org.uk> - 2016-01-19 19:10 +0100
    Re: [kernel-hardening] Re: 2015 kernel CVEs ebiederm@xmission.com (Eric W. Biederman) - 2016-01-20 00:00 +0100
  Re: [kernel-hardening] 2015 kernel CVEs ebiederm@xmission.com (Eric W. Biederman) - 2016-01-20 00:00 +0100
    Re: [kernel-hardening] 2015 kernel CVEs Jann Horn <jann@thejh.net> - 2016-01-20 21:20 +0100
      Re: [kernel-hardening] 2015 kernel CVEs One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-01-20 22:30 +0100
  Re: [kernel-hardening] 2015 kernel CVEs Kees Cook <keescook@chromium.org> - 2016-01-20 00:40 +0100
  Re: 2015 kernel CVEs Miroslav Benes <mbenes@suse.cz> - 2016-01-20 11:00 +0100

csiph-web