Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1312365

Re: net: hang in ip_finish_output

Show all headers | View raw

On Mon, Jan 18, 2016 at 9:49 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Mon, 2016-01-18 at 18:20 -0800, Eric Dumazet wrote:
>
>> Same reason really.
>>
>> Right after sk2=socket(), setsockopt(sk2,...,SO_REUSEPORT, on) and
>> bind(sk2, ...), but _before_ the connect(sk2) is done, sk2 is added into
>> the soreuseport array, with a score which is smaller than the score of
>> first socket sk1 found in hash table (I am speaking of the regular UDP
>> hash table), if sk1 had the connect() done, giving a +8 to its score.
>>
>> So the bug has nothing to do with rcu or rcu_bh, it is just an infinite
>> loop caused by different scores.
>>
>>
>> hash bucket [X] -> sk1 -> sk2 -> NULL
>>
>> sk1 score = 14  (because it did a connect())
>> sk2 score = 6
>>
>> I guess we should relax the test done after atomic_inc_not_zero_hint()
>> to only test the base keys :
>> (net, ipv6_only_sock, inet->inet_rcv_saddr & inet->inet_num)
>
> One way to fix the issue it to not call reuseport_select_sock() if loop
> was restarted, and fallback to the old mechanism : If the optimized
> version might have a problem, just fallback to the safe thing.

Ah, yes, this makes complete sense.  Thanks for the clarification.
It's obviously wrong to re-use this fast method in the case where the
loop in the lookup functions begins again.  I verified your patch
against Dmitry's test and it seems to work.  I think it makes sense to
move the 'select_ok = false' lines next to the 'goto begin' line
though.  It makes it more obvious that the fast lookup is incompatible
with the condition the goto handles.

I'll prepare this and the v6 version for review.  Do you think the
change to the scoring function for SO_INCOMING_CPU is still necessary
as well?  Thanks again!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: net: hang in ip_finish_output Craig Gallek <kraigatgoog@gmail.com> - 2016-01-18 19:40 +0100
  Re: net: hang in ip_finish_output Eric Dumazet <eric.dumazet@gmail.com> - 2016-01-19 03:30 +0100
    Re: net: hang in ip_finish_output Eric Dumazet <eric.dumazet@gmail.com> - 2016-01-19 03:50 +0100
      Re: net: hang in ip_finish_output Craig Gallek <kraigatgoog@gmail.com> - 2016-01-19 17:20 +0100
        [PATCH net] udp: fix potential infinite loop in SO_REUSEPORT logic Eric Dumazet <eric.dumazet@gmail.com> - 2016-01-19 17:40 +0100
          Re: [PATCH net] udp: fix potential infinite loop in SO_REUSEPORT logic Craig Gallek <kraigatgoog@gmail.com> - 2016-01-19 18:20 +0100
          Re: [PATCH net] udp: fix potential infinite loop in SO_REUSEPORT  logic David Miller <davem@davemloft.net> - 2016-01-19 20:00 +0100

csiph-web