Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1312203
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] sched: Consolidate nohz CPU load update code |
| Date | 2016-01-19 14:20 +0100 |
| Message-ID | <qSEmu-8o1-13@gated-at.bofh.it> (permalink) |
| References | <qQw9J-2at-33@gated-at.bofh.it> <qQw9J-2at-39@gated-at.bofh.it> <qQIud-2fD-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jan 14, 2016 at 02:18:40PM +0900, Byungchul Park wrote: > > + __update_cpu_load_nohz(this_rq, READ_ONCE(jiffies), 0, 0); > > This question is not directly related to this patch but I am just > curious about... Should we use READ_ONCE on jiffies which is already > volatile type? I'd say so, if only because I forever forget that jiffies is declared volatile and READ_ONCE() makes the intent explicit.
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 2/4] sched: Consolidate nohz CPU load update code Peter Zijlstra <peterz@infradead.org> - 2016-01-19 14:20 +0100
csiph-web