Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1311298

[PATCH 3.2 15/70] spi: fix parent-device reference leak

Show all headers | View raw

3.2.76-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Johan Hovold <johan@kernel.org>

commit 157f38f993919b648187ba341bfb05d0e91ad2f6 upstream.

Fix parent-device reference leak due to SPI-core taking an unnecessary
reference to the parent when allocating the master structure, a
reference that was never released.

Note that driver core takes its own reference to the parent when the
master device is registered.

Fixes: 49dce689ad4e ("spi doesn't need class_device")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 drivers/spi/spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -554,7 +554,7 @@ struct spi_master *spi_alloc_master(stru
 
 	device_initialize(&master->dev);
 	master->dev.class = &spi_master_class;
-	master->dev.parent = get_device(dev);
+	master->dev.parent = dev;
 	spi_master_set_devdata(master, &master[1]);
 
 	return master;

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3.2 00/70] 3.2.76-rc1 review Ben Hutchings <ben@decadent.org.uk> - 2016-01-18 04:50 +0100
  [PATCH 3.2 15/70] spi: fix parent-device reference leak Ben Hutchings <ben@decadent.org.uk> - 2016-01-18 04:50 +0100
  [PATCH 3.2 09/70] ALSA: tlv: compute TLV_*_ITEM lengths automatically Ben Hutchings <ben@decadent.org.uk> - 2016-01-18 04:50 +0100
  [PATCH 3.2 45/70] Revert "net: add length argument to  skb_copy_and_csum_datagram_iovec" Ben Hutchings <ben@decadent.org.uk> - 2016-01-18 04:50 +0100
  [PATCH 3.2 08/70] tty: Fix GPF in flush_to_ldisc() Ben Hutchings <ben@decadent.org.uk> - 2016-01-18 04:50 +0100
  [PATCH 3.2 11/70] ALSA: usb-audio: Add a more accurate volume  quirk for AudioQuest DragonFly Ben Hutchings <ben@decadent.org.uk> - 2016-01-18 04:50 +0100
  Re: [PATCH 3.2 00/70] 3.2.76-rc1 review Guenter Roeck <linux@roeck-us.net> - 2016-01-18 10:20 +0100
    Re: [PATCH 3.2 00/70] 3.2.76-rc1 review Ben Hutchings <ben@decadent.org.uk> - 2016-01-18 13:00 +0100

csiph-web