[PATCH 3.2 41/70] ftrace/scripts: Fix incorrect use of sprintf in recordmcount

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!feeds.phibee-telecom.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Ben Hutchings <ben@decadent.org.uk>
Newsgroups	linux.kernel
Subject	[PATCH 3.2 41/70] ftrace/scripts: Fix incorrect use of sprintf in recordmcount
Date	Mon, 18 Jan 2016 04:40:03 +0100
Message-ID	<qS8PF-3ml-41@gated-at.bofh.it> (permalink)
References	<qS8FX-3hu-3@gated-at.bofh.it>
Content-Type	text/plain; charset="UTF-8"
Content-Disposition	inline
Content-Transfer-Encoding	8bit
MIME-Version	1.0
X-Mailer	LinuxStableQueue (scripts by bwh)
X-Sa-Exim-Connect-IP	192.168.4.247
X-Sa-Exim-Mail-From	ben@decadent.org.uk
X-Sa-Exim-Scanned	No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	38
Organization	linux.* mail to news gateway
X-Original-Cc	akpm@linux-foundation.org, "Colin Ian King" <colin.king@canonical.com>, "Will Deacon" <will.deacon@arm.com>, "Russell King" <rmk+kernel@arm.linux.org.uk>, "Steven Rostedt" <rostedt@goodmis.org>, "Li Bin" <huawei.libin@huawei.com>
X-Original-Date	Mon, 18 Jan 2016 03:18:35 +0000
X-Original-Message-ID	<lsq.1453087115.140034941@decadent.org.uk>
X-Original-References	<lsq.1453087114.713093519@decadent.org.uk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1311278

Show key headers only | View raw

3.2.76-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Colin Ian King <colin.king@canonical.com>

commit 713a3e4de707fab49d5aa4bceb77db1058572a7b upstream.

Fix build warning:

scripts/recordmcount.c:589:4: warning: format not a string
literal and no format arguments [-Wformat-security]
    sprintf("%s: failed\n", file);

Fixes: a50bd43935586 ("ftrace/scripts: Have recordmcount copy the object file")
Link: http://lkml.kernel.org/r/1451516801-16951-1-git-send-email-colin.king@canonical.com

Cc: Li Bin <huawei.libin@huawei.com>
Cc: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 scripts/recordmcount.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/scripts/recordmcount.c
+++ b/scripts/recordmcount.c
@@ -546,7 +546,7 @@ main(int argc, char *argv[])
 			do_file(file);
 			break;
 		case SJ_FAIL:    /* error in do_file or below */
-			sprintf("%s: failed\n", file);
+			fprintf(stderr, "%s: failed\n", file);
 			++n_error;
 			break;
 		case SJ_SUCCEED:    /* premature success */

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 3.2 41/70] ftrace/scripts: Fix incorrect use of sprintf in  recordmcount Ben Hutchings <ben@decadent.org.uk> - 2016-01-18 04:40 +0100

csiph-web