Re: [PATCH v2] iio: light: acpi-als: Report data as processed

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] iio: light: acpi-als: Report data as processed
Date	2016-01-16 14:10 +0100
Message-ID	<qRyMb-4L7-13@gated-at.bofh.it> (permalink)
References	<qOkFJ-1wu-45@gated-at.bofh.it> <qQ93s-2Pd-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 12/01/16 15:21, Gabriele Mazzotta wrote:
> As per the ACPI specification (Revision 5.0) [1], the data coming
> from the sensor represent the ambient light illuminance reading
> expressed in lux. So use IIO_CHAN_INFO_PROCESSED to signify that
> the data are pre-processed.
> 
> However, to keep backward ABI compatibility, the IIO_CHAN_INFO_RAW
> bit is not removed.
> 
> [1] http://www.acpi.info/DOWNLOADS/ACPIspec50.pdf
> 
> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Applied to the fixes-togreg branch and marked for stable.

I added a bit to the commit message including that bug report you found for
iio-sensor-proxy as additional justification for the stable marking
and sending it as a fix.

Jonathan

> ---
>  drivers/iio/light/acpi-als.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/light/acpi-als.c b/drivers/iio/light/acpi-als.c
> index 60537ec..53201d9 100644
> --- a/drivers/iio/light/acpi-als.c
> +++ b/drivers/iio/light/acpi-als.c
> @@ -54,7 +54,9 @@ static const struct iio_chan_spec acpi_als_channels[] = {
>  			.realbits	= 32,
>  			.storagebits	= 32,
>  		},
> -		.info_mask_separate	= BIT(IIO_CHAN_INFO_RAW),
> +		/* _RAW is here for backward ABI compatibility */
> +		.info_mask_separate	= BIT(IIO_CHAN_INFO_RAW) |
> +					  BIT(IIO_CHAN_INFO_PROCESSED),
>  	},
>  };
>  
> @@ -152,7 +154,7 @@ static int acpi_als_read_raw(struct iio_dev *indio_dev,
>  	s32 temp_val;
>  	int ret;
>  
> -	if (mask != IIO_CHAN_INFO_RAW)
> +	if ((mask != IIO_CHAN_INFO_PROCESSED) && (mask != IIO_CHAN_INFO_RAW))
>  		return -EINVAL;
>  
>  	/* we support only illumination (_ALI) so far. */
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] iio: light: acpi-als: Report data as processed Jonathan Cameron <jic23@kernel.org> - 2016-01-16 14:10 +0100

csiph-web