Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1310356

Re: Re: [PATCH V2 1/7] usb-misc: sisusbvga: Fix coding style: horizontal whitespace changes

Show all headers | View raw

On Fri, 15 Jan 2016, Peter Senna wrote:

> CC: Alan Stern <stern@rowland.harvard.edu>
> 
> On Friday, January 15, 2016 18:56 CET, Joe Perches <joe@perches.com> wrote: 
>  
> > On Fri, 2016-01-15 at 18:41 +0100, Peter Senna Tschudin wrote:
> > > This patch fixes whitespace coding style issues that can be fixed
> > > within a single line.
> > 
> > trivia:
> > 
> > > diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
> > []
> > > @@ -549,7 +549,7 @@ static int sisusb_recv_bulk_msg(struct sisusb_usb_data *sisusb, int ep, int len,
> > >  }
> > >  
> > >  static int sisusb_send_packet(struct sisusb_usb_data *sisusb, int len,
> > > -						struct sisusb_packet *packet)
> > > +		struct sisusb_packet *packet)
> > 
> > I think all of these should use indentation alignment
> > to open parenthesis.
> That was my original idea too, but I have the impression things are different for usb, at least for usb-host. Alan, can you comment on this continuation line style issue here?

Different files use different alignment for continuation lines.  I use
the style I like (two extra tabs) for the code I write, but other
people make different choices.  Unless I happen to be the maintainer or
an active contributor for the source file in question, my preferences
don't matter much.

Alan Stern

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 0/7] usb-misc: sisusbvga: cleanup and bug fix Peter Senna Tschudin <peter.senna@collabora.com> - 2016-01-15 18:50 +0100
  [PATCH V2 5/7] usb-misc: sisusbvga: Remove null test before calls to kfree() Peter Senna Tschudin <peter.senna@collabora.com> - 2016-01-15 18:50 +0100
  Re: [PATCH V2 0/7] usb-misc: sisusbvga: cleanup and bug fix Joe Perches <joe@perches.com> - 2016-01-15 19:00 +0100
    Re: [PATCH V2 0/7] usb-misc: sisusbvga: cleanup and bug fix Jason Cooper <jason@lakedaemon.net> - 2016-01-15 19:10 +0100
  Re: [PATCH V2 1/7] usb-misc: sisusbvga: Fix coding style:  horizontal whitespace changes Joe Perches <joe@perches.com> - 2016-01-15 19:00 +0100
    Re: [PATCH V2 1/7] usb-misc: sisusbvga: Fix coding style: horizontal whitespace changes "Peter Senna" <peter.senna@collabora.co.uk> - 2016-01-15 19:10 +0100
      Re: Re: [PATCH V2 1/7] usb-misc: sisusbvga: Fix coding style: horizontal whitespace changes Alan Stern <stern@rowland.harvard.edu> - 2016-01-15 19:30 +0100

csiph-web