Re: gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detection

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	Re: gianfar: Less function calls in gfar_ethflow_to_filer_table() after error detection
Date	2016-01-15 18:40 +0100
Message-ID	<qRgvV-RW-19@gated-at.bofh.it> (permalink)
References	(2 earlier) <qR9ut-4CR-55@gated-at.bofh.it> <qR9E8-4Gx-45@gated-at.bofh.it> <qR9Xs-4OZ-25@gated-at.bofh.it> <qRb3c-5uT-13@gated-at.bofh.it> <qRbmy-5Tc-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>>> 	local_rqfpr = kmalloc_array(2 * (MAX_FILER_IDX + 1),
>>> 				    sizeof(unsigned int), GFP_KERNEL);
>>> 	if (!local_rqfpr)
>>> 		goto err;
>>>
>>> 	local_rqfcr = &local_rqfpr[MAX_FILER_IDX + 1];
>>
>> Do you suggest to use only one array (instead of two as before) here?
> 
> That's a possibility.

Thanks for your clarification.


> If, as your title suggests, you really want fewer function calls,

I am unsure at the moment if more changes will make sense in
this function implementation.


> (which as far as I saw, you didn't do)

Is my wording "after error detection" insufficient eventually?


> that could be a mechanism to remove both an allocation and a free.

Would any more software developers or source code reviewers like
to share their opinions in such a direction?

Regards,
Markus

Thread

[PATCH v3 0/3] gianfar: Fine-tuning for gfar_ethflow_to_filer_table() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-15 11:10 +0100
  [PATCH v3 3/3] gianfar: Extend an initialisation clause of a for loop  in gfar_ethflow_to_filer_table() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-15 11:20 +0100
  [PATCH v3 2/3] gianfar: Delete unnecessary variable initialisations  in gfar_ethflow_to_filer_table() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-15 11:20 +0100
    Re: [PATCH v3 2/3] gianfar: Delete unnecessary variable  initialisations in gfar_ethflow_to_filer_table() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-15 11:40 +0100
      Re: [PATCH v3 2/3] gianfar: Delete unnecessary variable  initialisations in gfar_ethflow_to_filer_table() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-15 12:40 +0100
        Re: [PATCH v3 2/3] gianfar: Delete unnecessary variable  initialisations in gfar_ethflow_to_filer_table() Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-15 13:20 +0100
        Re: [PATCH v3 2/3] gianfar: Delete unnecessary variable  initialisations in gfar_ethflow_to_filer_table() David Miller <davem@davemloft.net> - 2016-01-15 17:50 +0100
          Re: gianfar: Delete unnecessary variable initialisations in  gfar_ethflow_to_filer_table() SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-15 18:20 +0100
  [PATCH v3 1/3] gianfar: Less function calls in  gfar_ethflow_to_filer_table() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-15 11:20 +0100
    Re: [PATCH v3 1/3] gianfar: Less function calls in  gfar_ethflow_to_filer_table() after error detection Joe Perches <joe@perches.com> - 2016-01-15 11:40 +0100
      Re: gianfar: Less function calls in gfar_ethflow_to_filer_table()  after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-15 12:50 +0100
        Re: gianfar: Less function calls in gfar_ethflow_to_filer_table()  after error detection Joe Perches <joe@perches.com> - 2016-01-15 13:10 +0100
          Re: gianfar: Less function calls in gfar_ethflow_to_filer_table()  after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2016-01-15 18:40 +0100
            RE: gianfar: Less function calls in gfar_ethflow_to_filer_table()  after error detection Claudiu Manoil <claudiu.manoil@nxp.com> - 2016-01-18 15:50 +0100

csiph-web