Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1310300

RE: [RFC PATCH v3 3/5] PCI: Add host bridge attribute to indicate filtering of MSIs is supported

From David Laight <David.Laight@ACULAB.COM>
Newsgroups linux.kernel
Subject RE: [RFC PATCH v3 3/5] PCI: Add host bridge attribute to indicate filtering of MSIs is supported
Date 2016-01-15 18:30 +0100
Message-ID <qRgmd-OC-5@gated-at.bofh.it> (permalink)
References <qR6Gd-2DL-7@gated-at.bofh.it> <qR6Gd-2DL-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Yongji Xie
> Sent: 15 January 2016 07:06
>
> MSI-X tables are not allowed to be mmapped in vfio-pci
> driver in case that user get to touch this directly.
> This will cause some performance issues when when PCI
> adapters have critical registers in the same page as
> the MSI-X table.
...
If the driver wants to generate an incorrect MSI-X interrupt
it can do so by requesting the device do a normal memory transfer
to the target address area that raises MSI-X interrupts.
So disabling writes to the MSI-X table (and pending bit array)
areas only raises the bar very slightly.
A device may also give the driver write access to the MSI-X
table through other addresses.

This seems to make disallowing the mapping of the MSI-X table
rather pointless.

I've also dumped out the MSI-X table (during development) to
check that the values are being written there correctly.

	David

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC PATCH v3 3/5] PCI: Add host bridge attribute to indicate filtering of MSIs is supported Yongji Xie <xyjxie@linux.vnet.ibm.com> - 2016-01-15 08:10 +0100
  RE: [RFC PATCH v3 3/5] PCI: Add host bridge attribute to indicate  filtering of MSIs is supported David Laight <David.Laight@ACULAB.COM> - 2016-01-15 18:30 +0100
    Re: [RFC PATCH v3 3/5] PCI: Add host bridge attribute to indicate  filtering of MSIs is supported Yongji Xie <xyjxie@linux.vnet.ibm.com> - 2016-01-20 10:50 +0100

csiph-web