Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1310315

Re: [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing output clock to codec

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Jan 15, 2016 at 09:49:50PM +0800, Caesar Wang wrote:

> We need to claim the clock which is driving the codec so that when we
> enable clock gating, we continue to clock the codec when needed.
> I make this an optional clock since there might be some applications
> where we don't need it but can still use the I2S block.

> - As the perious discuss on https://patchwork.kernel.org/patch/5427131/,
>   I think Mark likes do it in codec driver, I have to say I agree this
>   patch in here since that's the i2s block output. I don't know if the
>   Mark has changed his mind.

If the I2S block is providing a clock to the CODEC then that's what the
software should do so that the CODEC can gate and ungate the clock as
required.  This patch has the I2S block using a clock, not providing
one.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing output clock to codec Caesar Wang <wxt@rock-chips.com> - 2016-01-15 15:00 +0100
  Re: [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing  output clock to codec Mark Brown <broonie@kernel.org> - 2016-01-15 18:50 +0100
    Re: [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing  output clock to codec Sonny Rao <sonnyrao@chromium.org> - 2016-01-15 22:50 +0100
      Re: [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing  output clock to codec Mark Brown <broonie@kernel.org> - 2016-01-22 18:20 +0100
        Re: [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing  output clock to codec Jianqun Xu <jay.xu@rock-chips.com> - 2016-01-25 02:20 +0100
          Re: [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing output clock to codec Heiko Stübner <heiko@sntech.de> - 2016-01-26 11:00 +0100
            Re: [PATCH v3 3/9] ASoC: rockchip: i2s: add support for grabbing  output clock to codec Mark Brown <broonie@kernel.org> - 2016-01-27 13:50 +0100

csiph-web