Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1310233
| From | Stefano Stabellini <stefano.stabellini@eu.citrix.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 01/16] Xen: ACPI: Hide UART used by Xen |
| Date | 2016-01-15 16:50 +0100 |
| Message-ID | <qReNt-89q-29@gated-at.bofh.it> (permalink) |
| References | <qR6wx-2kF-3@gated-at.bofh.it> <qR6wz-2kF-37@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 15 Jan 2016, Shannon Zhao wrote:
> From: Shannon Zhao <shannon.zhao@linaro.org>
>
> ACPI 6.0 introduces a new table STAO to list the devices which are used
> by Xen and can't be used by Dom0. On Xen virtual platforms, the physical
> UART is used by Xen. So here it hides UART from Dom0.
>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> CC: "Rafael J. Wysocki" <rjw@rjwysocki.net> (supporter:ACPI)
> CC: Len Brown <lenb@kernel.org> (supporter:ACPI)
> CC: linux-acpi@vger.kernel.org (open list:ACPI)
> ---
> drivers/acpi/bus.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index a212cef..d7a559f 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -46,6 +46,7 @@ ACPI_MODULE_NAME("bus");
> struct acpi_device *acpi_root;
> struct proc_dir_entry *acpi_root_dir;
> EXPORT_SYMBOL(acpi_root_dir);
> +static u64 spcr_uart_addr;
>
> #ifdef CONFIG_X86
> #ifdef CONFIG_ACPI_CUSTOM_DSDT
> @@ -93,6 +94,17 @@ acpi_status acpi_bus_get_status_handle(acpi_handle handle,
> {
> acpi_status status;
>
> + if (spcr_uart_addr != 0xffffffffffffffff) {
Please #define something like EFI_INVALID_TABLE_ADDR and use it here
instead of 0xffffffffffffffff for readability. Also spcr_uart_addr could
be initialized where it is defined.
Maybe it could be better to move this check into a separate function and
only call acpi_set_device_status if spcr_uart_addr != addr?
> + u64 addr;
> +
> + status = acpi_evaluate_integer(handle, METHOD_NAME__ADR, NULL,
> + &addr);
> + if (ACPI_SUCCESS(status) && (addr == spcr_uart_addr)) {
> + *sta = 0;
> + return AE_OK;
> + }
> + }
> +
> status = acpi_evaluate_integer(handle, "_STA", NULL, sta);
> if (ACPI_SUCCESS(status))
> return AE_OK;
> @@ -1069,6 +1081,8 @@ EXPORT_SYMBOL_GPL(acpi_kobj);
> static int __init acpi_init(void)
> {
> int result;
> + acpi_status status;
> + struct acpi_table_stao *stao_ptr;
>
> if (acpi_disabled) {
> printk(KERN_INFO PREFIX "Interpreter disabled.\n");
> @@ -1081,6 +1095,22 @@ static int __init acpi_init(void)
> acpi_kobj = NULL;
> }
>
> + /* If there is STAO table, check whether it needs to ignore the UART
> + * device in SPCR table.
> + */
> + spcr_uart_addr = 0xffffffffffffffff;
> + status = acpi_get_table(ACPI_SIG_STAO, 0,
> + (struct acpi_table_header **)&stao_ptr);
> + if (ACPI_SUCCESS(status)) {
> + if (stao_ptr->ignore_uart) {
if (ACPI_SUCCESS(status) && stao_ptr->ignore_uart) {
> + struct acpi_table_spcr *spcr_ptr;
> +
> + acpi_get_table(ACPI_SIG_SPCR, 0,
> + (struct acpi_table_header **)&spcr_ptr);
Maybe we should check that acpi_get_table succeeded, even though it
should at this point.
> + spcr_uart_addr = spcr_ptr->serial_port.address;
> + }
> + }
> +
> init_acpi_device_notify();
> result = acpi_bus_init();
> if (result) {
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 00/16] Add ACPI support for Xen Dom0 on ARM64 Shannon Zhao <zhaoshenglong@huawei.com> - 2016-01-15 08:00 +0100
[PATCH v2 01/16] Xen: ACPI: Hide UART used by Xen Shannon Zhao <zhaoshenglong@huawei.com> - 2016-01-15 08:00 +0100
Re: [PATCH v2 01/16] Xen: ACPI: Hide UART used by Xen Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-15 16:50 +0100
Re: [PATCH v2 01/16] Xen: ACPI: Hide UART used by Xen Mark Rutland <mark.rutland@arm.com> - 2016-01-18 11:40 +0100
Re: [PATCH v2 01/16] Xen: ACPI: Hide UART used by Xen Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-18 12:40 +0100
[PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Shannon Zhao <zhaoshenglong@huawei.com> - 2016-01-15 08:00 +0100
Re: [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Mark Rutland <mark.rutland@arm.com> - 2016-01-18 12:10 +0100
Re: [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-18 18:50 +0100
Re: [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Mark Rutland <mark.rutland@arm.com> - 2016-01-18 19:30 +0100
Re: [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-19 13:10 +0100
Re: [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Mark Rutland <mark.rutland@arm.com> - 2016-01-19 14:10 +0100
Re: [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Shannon Zhao <shannon.zhao@linaro.org> - 2016-01-19 14:40 +0100
Re: [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-19 15:30 +0100
Re: [Xen-devel] [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-18 18:10 +0100
Re: [Xen-devel] [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Shannon Zhao <shannon.zhao@linaro.org> - 2016-01-19 14:20 +0100
Re: [Xen-devel] [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-19 15:30 +0100
Re: [Xen-devel] [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Shannon Zhao <zhaoshenglong@huawei.com> - 2016-01-22 05:00 +0100
Re: [Xen-devel] [PATCH v2 16/16] ARM64: XEN: Initialize Xen specific UEFI runtime services Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-22 12:10 +0100
[PATCH v2 10/16] ARM: XEN: Move xen_early_init() before efi_init() Shannon Zhao <zhaoshenglong@huawei.com> - 2016-01-15 08:00 +0100
Re: [Xen-devel] [PATCH v2 10/16] ARM: XEN: Move xen_early_init() before efi_init() Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-18 16:10 +0100
Re: [Xen-devel] [PATCH v2 10/16] ARM: XEN: Move xen_early_init() before efi_init() Shannon Zhao <zhaoshenglong@huawei.com> - 2016-01-19 09:40 +0100
Re: [Xen-devel] [PATCH v2 10/16] ARM: XEN: Move xen_early_init() before efi_init() Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-19 13:20 +0100
[PATCH v2 05/16] xen: memory : Add new XENMAPSPACE type XENMAPSPACE_dev_mmio Shannon Zhao <zhaoshenglong@huawei.com> - 2016-01-15 08:10 +0100
[PATCH v2 04/16] arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table Shannon Zhao <zhaoshenglong@huawei.com> - 2016-01-15 08:10 +0100
Re: [PATCH v2 04/16] arm/xen: Use xen_xlate_map_ballooned_pages to setup grant table Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-15 18:30 +0100
[PATCH v2 09/16] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI Shannon Zhao <zhaoshenglong@huawei.com> - 2016-01-15 08:10 +0100
Re: [Xen-devel] [PATCH v2 09/16] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2016-01-18 15:40 +0100
Re: [Xen-devel] [PATCH v2 09/16] arm/xen: Get event-channel irq through HVM_PARAM when booting with ACPI Shannon Zhao <zhaoshenglong@huawei.com> - 2016-01-19 09:30 +0100
csiph-web