Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1310173
| From | Cyrille Pitchen <cyrille.pitchen@atmel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 5/5] crypto: atmel-sha: fix algorihtm registration |
| Date | 2016-01-15 16:00 +0100 |
| Message-ID | <qRe14-7zo-9@gated-at.bofh.it> (permalink) |
| References | <qRdRn-7uO-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
This patch implements the missing .import() and .export() mandatory
hooks for asynchronous hash algorithms. It also sets the relevant, non
zero, value for the .statesize field when declaring the supported SHA
algorithms. Indeed a zero value of .statesize prevents the algorithm from
being registered.
Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com>
---
drivers/crypto/atmel-sha.c | 55 +++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 54 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index da4c3055784f..ad6a0df47ccd 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -66,7 +66,7 @@
#define SHA_OP_UPDATE 1
#define SHA_OP_FINAL 2
-#define SHA_BUFFER_LEN PAGE_SIZE
+#define SHA_BUFFER_LEN (PAGE_SIZE / 16)
#define ATMEL_SHA_DMA_THRESHOLD 56
@@ -80,6 +80,17 @@ struct atmel_sha_caps {
struct atmel_sha_dev;
+/*
+ * .statesize = sizeof(struct atmel_sha_state) must be <= PAGE_SIZE / 8 as
+ * tested by the ahash_prepare_alg() function.
+ */
+struct atmel_sha_state {
+ u8 digest[SHA512_DIGEST_SIZE];
+ u8 buffer[SHA_BUFFER_LEN];
+ u64 digcnt[2];
+ size_t bufcnt;
+};
+
struct atmel_sha_reqctx {
struct atmel_sha_dev *dd;
unsigned long flags;
@@ -1033,6 +1044,33 @@ static int atmel_sha_digest(struct ahash_request *req)
return atmel_sha_init(req) ?: atmel_sha_finup(req);
}
+
+static int atmel_sha_export(struct ahash_request *req, void *out)
+{
+ const struct atmel_sha_reqctx *ctx = ahash_request_ctx(req);
+ struct atmel_sha_state *state = out;
+
+ memcpy(state->digest, ctx->digest, SHA512_DIGEST_SIZE);
+ memcpy(state->buffer, ctx->buffer, ctx->bufcnt);
+ state->bufcnt = ctx->bufcnt;
+ state->digcnt[0] = ctx->digcnt[0];
+ state->digcnt[1] = ctx->digcnt[1];
+ return 0;
+}
+
+static int atmel_sha_import(struct ahash_request *req, const void *in)
+{
+ struct atmel_sha_reqctx *ctx = ahash_request_ctx(req);
+ const struct atmel_sha_state *state = in;
+
+ memcpy(ctx->digest, state->digest, SHA512_DIGEST_SIZE);
+ memcpy(ctx->buffer, state->buffer, state->bufcnt);
+ ctx->bufcnt = state->bufcnt;
+ ctx->digcnt[0] = state->digcnt[0];
+ ctx->digcnt[1] = state->digcnt[1];
+ return 0;
+}
+
static int atmel_sha_cra_init(struct crypto_tfm *tfm)
{
crypto_ahash_set_reqsize(__crypto_ahash_cast(tfm),
@@ -1049,8 +1087,11 @@ static struct ahash_alg sha_1_256_algs[] = {
.final = atmel_sha_final,
.finup = atmel_sha_finup,
.digest = atmel_sha_digest,
+ .export = atmel_sha_export,
+ .import = atmel_sha_import,
.halg = {
.digestsize = SHA1_DIGEST_SIZE,
+ .statesize = sizeof(struct atmel_sha_state),
.base = {
.cra_name = "sha1",
.cra_driver_name = "atmel-sha1",
@@ -1070,8 +1111,11 @@ static struct ahash_alg sha_1_256_algs[] = {
.final = atmel_sha_final,
.finup = atmel_sha_finup,
.digest = atmel_sha_digest,
+ .export = atmel_sha_export,
+ .import = atmel_sha_import,
.halg = {
.digestsize = SHA256_DIGEST_SIZE,
+ .statesize = sizeof(struct atmel_sha_state),
.base = {
.cra_name = "sha256",
.cra_driver_name = "atmel-sha256",
@@ -1093,8 +1137,11 @@ static struct ahash_alg sha_224_alg = {
.final = atmel_sha_final,
.finup = atmel_sha_finup,
.digest = atmel_sha_digest,
+ .export = atmel_sha_export,
+ .import = atmel_sha_import,
.halg = {
.digestsize = SHA224_DIGEST_SIZE,
+ .statesize = sizeof(struct atmel_sha_state),
.base = {
.cra_name = "sha224",
.cra_driver_name = "atmel-sha224",
@@ -1116,8 +1163,11 @@ static struct ahash_alg sha_384_512_algs[] = {
.final = atmel_sha_final,
.finup = atmel_sha_finup,
.digest = atmel_sha_digest,
+ .export = atmel_sha_export,
+ .import = atmel_sha_import,
.halg = {
.digestsize = SHA384_DIGEST_SIZE,
+ .statesize = sizeof(struct atmel_sha_state),
.base = {
.cra_name = "sha384",
.cra_driver_name = "atmel-sha384",
@@ -1137,8 +1187,11 @@ static struct ahash_alg sha_384_512_algs[] = {
.final = atmel_sha_final,
.finup = atmel_sha_finup,
.digest = atmel_sha_digest,
+ .export = atmel_sha_export,
+ .import = atmel_sha_import,
.halg = {
.digestsize = SHA512_DIGEST_SIZE,
+ .statesize = sizeof(struct atmel_sha_state),
.base = {
.cra_name = "sha512",
.cra_driver_name = "atmel-sha512",
--
1.8.2.2
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/5] crypto: atmel-sha: fix registration issue and other bugs Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-01-15 15:50 +0100
[PATCH 3/5] crypto: atmel-sha: add support of sama5d2x SoCs Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-01-15 15:50 +0100
[PATCH 2/5] crypto: atmel-sha: fix a race between the 'done' tasklet and the crypto client Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-01-15 15:50 +0100
[PATCH 5/5] crypto: atmel-sha: fix algorihtm registration Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-01-15 16:00 +0100
Re: [PATCH 5/5] crypto: atmel-sha: fix algorihtm registration Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-25 08:30 +0100
[PATCH 4/5] crypto: atmel-sha: fix context switches Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-01-15 16:00 +0100
Re: [PATCH 0/5] crypto: atmel-sha: fix registration issue and other bugs Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-01-22 18:00 +0100
Re: [PATCH 0/5] crypto: atmel-sha: fix registration issue and other bugs Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-25 08:30 +0100
Re: [PATCH 0/5] crypto: atmel-sha: fix registration issue and other bugs Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-25 15:50 +0100
Re: [PATCH 0/5] crypto: atmel-sha: fix registration issue and other bugs Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2016-01-25 16:00 +0100
csiph-web