Re: [PATCH v4 1/2] memory-hotplug: add automatic onlining policy for the newly added memory

From	Vitaly Kuznetsov <vkuznets@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 1/2] memory-hotplug: add automatic onlining policy for the newly added memory
Date	2016-01-15 14:20 +0100
Message-ID	<qRcsi-6zK-21@gated-at.bofh.it> (permalink)
References	(2 earlier) <qQgRk-85b-9@gated-at.bofh.it> <qQrtn-7g1-7@gated-at.bofh.it> <qQEqC-7BF-3@gated-at.bofh.it> <qQLLs-4xW-5@gated-at.bofh.it> <qQXWi-4xw-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

David Rientjes <rientjes@google.com> writes:

> On Thu, 14 Jan 2016, Vitaly Kuznetsov wrote:
>
>> > My suggestion is to just simply document that auto-onlining can add the 
>> > memory but fail to online it and the failure is silent to userspace.  If 
>> > userspace cares, it can check the online status of the added memory blocks 
>> > itself.
>> 
>> The problem is not only that it's silent, but also that
>> /sys/devices/system/memory/*/state will lie as we create all memory
>> blocks in MEM_ONLINE state and from online_pages() error we can't figure
>> out which particular block failed. 'v5' which I sent yesterday is
>> supposed to fix the issue (blocks are onlined with
>> memory_block_change_state() which handles failures.
>> 
>
> Would you mind documenting that in the memory-hotplug.txt as an add-on 
> patch to your v5, which appears ready to go?

Sure,

I'll mention possible failures diring automatic onlining. It seems v5
wasn't picked by Andrew and I also have one nitpick in PATCH 2 to
address so I'll send v6.

Thanks,

-- 
  Vitaly

Thread

[PATCH v4 1/2] memory-hotplug: add automatic onlining policy for the newly added memory Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-01-12 18:00 +0100
  Re: [PATCH v4 1/2] memory-hotplug: add automatic onlining policy  for the newly added memory David Rientjes <rientjes@google.com> - 2016-01-13 00:50 +0100
    Re: [PATCH v4 1/2] memory-hotplug: add automatic onlining policy for the newly added memory Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-01-13 12:10 +0100
      Re: [PATCH v4 1/2] memory-hotplug: add automatic onlining policy  for the newly added memory David Rientjes <rientjes@google.com> - 2016-01-14 02:00 +0100
        Re: [PATCH v4 1/2] memory-hotplug: add automatic onlining policy for the newly added memory Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-01-14 09:50 +0100
          Re: [PATCH v4 1/2] memory-hotplug: add automatic onlining policy  for the newly added memory David Rientjes <rientjes@google.com> - 2016-01-14 22:50 +0100
            Re: [PATCH v4 1/2] memory-hotplug: add automatic onlining policy for the newly added memory Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-01-15 14:20 +0100
  Re: [PATCH v4 1/2] memory-hotplug: add automatic onlining policy for  the newly added memory Daniel Kiper <daniel.kiper@oracle.com> - 2016-01-13 09:10 +0100

csiph-web