Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1310053

Re: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype

From Emil Velikov <emil.l.velikov@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype
Date 2016-01-15 12:10 +0100
Message-ID <qRaqu-5f3-33@gated-at.bofh.it> (permalink)
References <qQtYe-s0-13@gated-at.bofh.it> <qQu7U-vr-5@gated-at.bofh.it> <qQuhz-Oj-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 13 January 2016 at 16:00, Arnd Bergmann <arnd@arndb.de> wrote:
> On Wednesday 13 January 2016 14:55:47 Karol Herbst wrote:
>> > Arnd Bergmann <arnd@arndb.de> hat am 13. Januar 2016 um 14:48 geschrieben:
>> >
>> > The new debugfs initialization code fails to build when CONFIG_DEBUG_FS
>> > is disabled:
>> >
>> > In file included from /git/arm-soc/drivers/gpu/drm/nouveau/nouveau_drm.c:57:0:
>> > drivers/gpu/drm/nouveau/nouveau_debugfs.h: In function 'nouveau_debugfs_init':
>> > drivers/gpu/drm/nouveau/nouveau_debugfs.h:37:29: error: parameter name omitted
>> >  nouveau_debugfs_init(struct nouveau_drm *)
>> >
>> > This fixes the prototypes so we can build it again.
>> >
>>
>> thanks for this. I already send a patch to the nouveau ML here:
>> http://lists.freedesktop.org/archives/nouveau/2016-January/023779.html
>
> Ok, thanks
>
Fwiw Arnd's fix feels a lot better - it lacks typos, has a fixes tag,
comprehensive commit message etc. etc. :-)

-Emil

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Arnd Bergmann <arnd@arndb.de> - 2016-01-13 14:50 +0100
  Re: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Karol Herbst <nouveau@karolherbst.de> - 2016-01-13 15:00 +0100
    Re: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Arnd Bergmann <arnd@arndb.de> - 2016-01-13 15:10 +0100
      Re: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Emil Velikov <emil.l.velikov@gmail.com> - 2016-01-15 12:10 +0100
        Re: [PATCH] drm: nouveau: fix nouveau_debugfs_init prototype Karol Herbst <nouveau@karolherbst.de> - 2016-01-15 13:10 +0100

csiph-web