Re: [RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Heiko Stuebner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed
Date	Sun, 17 Jan 2016 16:30:02 +0100
Message-ID	<qRXrc-4ar-7@gated-at.bofh.it> (permalink)
References	<qQtbQ-8i8-11@gated-at.bofh.it>
X-Original-To	John Keeping <john@metanate.com>
User-Agent	KMail/4.14.10 (Linux/4.3.0-1-amd64; KDE/4.14.14; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="us-ascii"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	34
Organization	linux.* mail to news gateway
X-Original-Cc	Mark Yao <mark.yao@rock-chips.com>, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Sun, 17 Jan 2016 16:21:08 +0100
X-Original-Message-ID	<5745581.hZKD3MVpjF@phil>
X-Original-References	<1452689614-6570-1-git-send-email-john@metanate.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1311158

Show key headers only | View raw

Am Mittwoch, 13. Januar 2016, 12:53:34 schrieb John Keeping:
> As commented in drm_atomic_helper_wait_for_vblanks(), userspace relies
> on cursor ioctls being unsynced.  Converting the rockchip driver to
> atomic has significantly impacted cursor performance by making every
> cursor update wait for vblank.
> 
> By skipping the vblank sync when the framebuffer has not changed (as is
> done in drm_atomic_helper_wait_for_vblanks()) we can avoid this for the
> common case of moving the cursor and only need to delay the cursor ioctl
> when the cursor icon changes.
> 
> I originally inserted a check on legacy_cursor_update as well, but that
> caused a storm of iommu page faults.  I didn't investigate the cause of
> those since this change gives enough of a performance improvement for my
> use case.
> 
> This is RFC because of that and because the framebuffer_changed()
> function is copied from drm_atomic_helper.c as a quick way to test the
> result.
> 
> Signed-off-by: John Keeping <john@metanate.com>

I've seen the effects now as well after making the atomic parts work on in 
my devtree - i.e. sluggish cursor movements.

This patch fixes that issue, so at least:
Tested-by: Heiko Stuebner <heiko@sntech.de>


Right now I still see flickering on animated cursors though (like ones used 
by KDE), that wasn't present before.


Heiko

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC/PATCH] drm/rockchip: don't wait for vblank if fb hasn't changed Heiko Stuebner <heiko@sntech.de> - 2016-01-17 16:30 +0100

csiph-web