Re: [PATCH] Restrict read access to private module signing key

From	Luis Ressel <aranea@aixah.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Restrict read access to private module signing key
Date	2016-01-17 00:10 +0100
Message-ID	<qRI8N-2E7-5@gated-at.bofh.it> (permalink)
References	<qRI8N-2E7-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat,  2 Jan 2016 16:13:50 +0100
Luis Ressel <aranea@aixah.de> wrote:

> The autogenerated module signing key shouldn't be world-readable.
> 
> Signed-off-by: Luis Ressel <aranea@aixah.de>
> ---
>  certs/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/certs/Makefile b/certs/Makefile
> index 28ac694..7f1f082 100644
> --- a/certs/Makefile
> +++ b/certs/Makefile
> @@ -49,6 +49,8 @@ $(obj)/signing_key.pem: $(obj)/x509.genkey
>  	@echo "### needs to be run as root, and uses a hardware
> random" @echo "### number generator if one is available."
>  	@echo "###"
> +	touch $(obj)/signing_key.pem
> +	chmod 0600 $(obj)/signing_key.pem
>  	openssl req -new -nodes -utf8 -$(CONFIG_MODULE_SIG_HASH)
> -days 36500 \ -batch -x509 -config $(obj)/x509.genkey \
>  		-outform PEM -out $(obj)/signing_key.pem \

I've contributed this patch two weeks ago, but there hasn't been any
feedback and it hasn't been merged, either. It's the first kernel patch
I've submitted, so I don't know much about the procedures here. Could
someone please merge the patch or point out any problems with it?

Regards,
Luis Ressel

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] Restrict read access to private module signing key Luis Ressel <aranea@aixah.de> - 2016-01-17 00:10 +0100

csiph-web