Re: [PATCH v2 3/9] perf build: Test correct path of perf in build-test

From	"Wangnan (F)" <wangnan0@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/9] perf build: Test correct path of perf in build-test
Date	2016-01-15 04:40 +0100
Message-ID	<qR3oZ-dt-7@gated-at.bofh.it> (permalink)
References	(2 earlier) <qQRxx-8vf-33@gated-at.bofh.it> <qQRxx-8vf-41@gated-at.bofh.it> <qQRHc-nE-5@gated-at.bofh.it> <qQSjT-Dz-1@gated-at.bofh.it> <qR2Mi-85x-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 2016/1/15 10:57, Wangnan (F) wrote:
>
>
[SNIP]
>
> Concultion: the reason of the problem you met is because 'make clean 
> O=.' doesn't clean
> feature test results. In v1 I have:
>
> -clean := @(cd $(PERF); make -s -f $(MK) clean >/dev/null)
> +clean := @(cd $(PERF); make -s -f $(MK) O=$(PERF_OUT) clean 
> >/dev/null; make -s -f $(MK) clean >/dev/null)
>
> (two 'make clean' here for safety)
>
> But removes them in v2. The second 'make clean' would remove any 
> feature testing
> results and return good testing result for you. This also explain why 
> I never met failure
> like this: if patch 4 - 9 are applied, make static would use feature 
> dump.
>
> Let me see how to remove feature testing results.

Here:

config-clean:
         $(call QUIET_CLEAN, config)
         $(Q)$(MAKE) -C $(srctree)/tools/build/feature/ $(if 
$(OUTPUT),OUTPUT=$(OUTPUT)feature/,) clean >/dev/null

If we build with 'O', feature test directory would reside in 
$(OUTPUT)/feature. Then when
we 'make clean', the resuling .bin files are removed from 
$(OUTPUT)/feature. However, if we
build without 'O' but clean with 'O=.', make clean tries to remove 
./feature, but should be
../build/feature.

Thank you.

Thread

[PATCH v2 3/9] perf build: Test correct path of perf in build-test Wang Nan <wangnan0@huawei.com> - 2016-01-14 14:20 +0100
  Re: [PATCH v2 3/9] perf build: Test correct path of perf in  build-test Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-14 16:00 +0100
    Re: [PATCH v2 3/9] perf build: Test correct path of perf in  build-test Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-14 16:00 +0100
      Re: [PATCH v2 3/9] perf build: Test correct path of perf in build-test pi3orama <pi3orama@163.com> - 2016-01-14 16:10 +0100
        Re: [PATCH v2 3/9] perf build: Test correct path of perf in  build-test Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-14 16:50 +0100
          Re: [PATCH v2 3/9] perf build: Test correct path of perf in  build-test Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-14 17:10 +0100
            Re: [PATCH v2 3/9] perf build: Test correct path of perf in  build-test Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-14 18:40 +0100
          Re: [PATCH v2 3/9] perf build: Test correct path of perf in build-test "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-15 04:00 +0100
            Re: [PATCH v2 3/9] perf build: Test correct path of perf in build-test "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-15 04:40 +0100
      Re: [PATCH v2 3/9] perf build: Test correct path of perf in build-test "Wangnan (F)" <wangnan0@huawei.com> - 2016-01-15 03:30 +0100

csiph-web