Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1309849

Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options

Show all headers | View raw

On Thu, Jan 14, 2016 at 07:31:19PM -0600, Timur Tabi wrote:
> Nicolin Chen wrote:
> >I think DT maintainers may not give a consent towards these two
> >properties as they are not to describe the hardware but to hack
> >software configurations. (And it seems you haven't CCed them.)
> 
> I admit it's a grey area, but the hardware doesn't work if you use the wrong
> value, and it is a fixed value per device.  A p1022ds would use a different
> value than in in i.MX6, and once you pick a value, it's the same no matter
> which sample rate, buffer size, etc you choose.

We've allowed similar properties for other things like SPI controllers.

It really depends on the frequency you expect to change it. The more 
often it changes, the higher up the s/w stack it should be controlled 
(firmware/DT, kernel, or userspace). A function of the SOC or codec 
rate, then yes DT is fine. Every user needs to tune it on the same 
platform, then no, don't put it in DT. My recollection from i.MX is this 
would be the former case.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-14 17:30 +0100
  Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-14 21:20 +0100
    Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-14 22:30 +0100
      Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 03:50 +0100
        Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-15 06:00 +0100
          Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 19:20 +0100
    Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-15 02:40 +0100
      Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 03:40 +0100
      Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Rob Herring <robh@kernel.org> - 2016-01-15 04:30 +0100
      Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Mark Brown <broonie@kernel.org> - 2016-01-15 14:20 +0100
        Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-15 14:50 +0100
          Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-15 18:10 +0100
            Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 19:40 +0100
              Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-15 19:50 +0100
                Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 20:00 +0100
                Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-15 20:20 +0100
                Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Nicolin Chen <nicoleotsuka@gmail.com> - 2016-01-15 20:30 +0100
                Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-15 20:50 +0100
                Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-16 15:20 +0100
                Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Caleb Crome <caleb@crome.org> - 2016-01-18 00:40 +0100
              Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst  settings device tree options Timur Tabi <timur@tabi.org> - 2016-01-15 21:00 +0100

csiph-web