Re: [PATCH 2/3] mmc: sdhci-pci: Add platform tuning callback for amd hs200 mode

From	Wan Zongshun <vw@iommu.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] mmc: sdhci-pci: Add platform tuning callback for amd hs200 mode
Date	2016-01-15 02:50 +0100
Message-ID	<qR1Gy-7or-3@gated-at.bofh.it> (permalink)
References	<qIrTB-2h1-15@gated-at.bofh.it> <qIuoq-3Xz-11@gated-at.bofh.it> <qQ8h4-2fU-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>>
>> But I also met trouble in sdhci_execute_tuning of sdhci.c, I have to suppose
>> only sdhci_pci_platform_execute_tuning is returning -EPERM(current code,
>> my assumption is right), so that those vendor that has no
>> slot->platform_execute_tuning could be skipped and go next standard
>> tuning process.
>>
>> If you have better idea for my requirement, please correct me.
>
> sdhci needs to become a set of library functions.
>
> Typically the mmc_host_ops ->execute_tuning() callback for sdhci,
> should be assigned to a default function, unless the sdhci variant has
> assigned it to something else.
>
> Yes, I realize that it requires core changes to sdhci to allow this.
> Although it's necessary do this conversion as I won't accept any more
> changes for sdhci that doesn't move the code into this direction.
>

Ulf,

Then Can you point me what's my next step for submitting tuning 
workaround for AMD emmc4.5 driver?

What your mean is you will change sdhci-pci-core.c to a core and library 
function?
And then I can implement a AMD specific emmc-pci driver call to those libs?


> Kind regards
> Uffe
>
>>
>> Thanks!
>> Wan Zongshun.
>>
>> ---
>>   drivers/mmc/host/sdhci-pci-core.c | 23 +++++++++++++++++++++++
>>   drivers/mmc/host/sdhci-pci.h      |  1 +
>>   drivers/mmc/host/sdhci.c          |  3 ++-
>>   3 files changed, 26 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
>> index 01c5723..e7b2bbe 100644
>> --- a/drivers/mmc/host/sdhci-pci-core.c
>> +++ b/drivers/mmc/host/sdhci-pci-core.c
>> @@ -905,8 +905,19 @@ static int amd_probe(struct sdhci_pci_chip *chip)
>>          return 0;
>>   }
>>

Thread

Re: [PATCH 2/3] mmc: sdhci-pci: Add platform tuning callback for amd  hs200 mode Ulf Hansson <ulf.hansson@linaro.org> - 2016-01-12 15:40 +0100
  Re: [PATCH 2/3] mmc: sdhci-pci: Add platform tuning callback for amd  hs200 mode Wan Zongshun <vw@iommu.org> - 2016-01-15 02:50 +0100
    Re: [PATCH 2/3] mmc: sdhci-pci: Add platform tuning callback for amd  hs200 mode Ulf Hansson <ulf.hansson@linaro.org> - 2016-01-15 08:30 +0100

csiph-web