Re: [PATCH v5 09/15] tty: serial: 8250: Fix multi-line strings

From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 09/15] tty: serial: 8250: Fix multi-line strings
Date	2016-01-13 18:20 +0100
Message-ID	<qQxft-2SP-15@gated-at.bofh.it> (permalink)
References	<qQwCK-2o0-19@gated-at.bofh.it> <qQwMq-2sp-7@gated-at.bofh.it>
Organization	Intel Finland Oy

Show all headers | View raw

On Wed, 2016-01-13 at 17:39 +0100, Anton Wuerfel wrote:
> Merged user-visible multi-line strings into a single line according
> to the
> Linux Kernel Coding Style, which allows user-visible strings to
> exceed the
> maximum line length of 80 characters. The main reason for this is to
> facilitate grepping for these strings.
> However, some strings were ignored in this patch, because the use of
> format specifiers breaks the ability to grep anyway.
> 

> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -1173,8 +1173,7 @@ MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("Generic 8250/16x50 serial driver");
>  
>  module_param(share_irqs, uint, 0644);
> -MODULE_PARM_DESC(share_irqs, "Share IRQs with other non-8250/16x50
> devices"
> -	" (unsafe)");
> +MODULE_PARM_DESC(share_irqs, "Share IRQs with other non-8250/16x50
> devices (unsafe)");

This one looks nice in one line.

> --- a/drivers/tty/serial/8250/serial_cs.c
> +++ b/drivers/tty/serial/8250/serial_cs.c
> @@ -533,8 +533,7 @@ static int multi_config(struct pcmcia_device
> *link)
>  		info->multi = 2;
>  		if (pcmcia_loop_config(link,
> multi_config_check_notpicky,
>  				       &base2)) {
> -			dev_warn(&link->dev, "no usable port range "
> -			       "found, giving up\n");
> +			dev_warn(&link->dev, "no usable port range
> found, giving up\n");

But here I would comment as in patch 5, i.e. move literal to next line
it it doesn't fit on the dev_warn() line.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Thread

[PATCH v5 00/15] tty: serial: 8250: Fix checkpatch warnings Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
  [PATCH v5 09/15] tty: serial: 8250: Fix multi-line strings Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
    Re: [PATCH v5 09/15] tty: serial: 8250: Fix multi-line strings Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-13 18:20 +0100
  [PATCH v5 10/15] tty: serial: 8250: Suitably replace printk Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
  [PATCH v5 06/15] tty: serial: 8250: Move EXPORT_SYMBOL to function Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
  [PATCH v5 05/15] tty: serial: 8250: Remove else after return Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
    Re: [PATCH v5 05/15] tty: serial: 8250: Remove else after return Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-13 18:20 +0100
  [PATCH v5 15/15] tty: serial: 8250: Merge duplicate conditions Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
    Re: [PATCH v5 15/15] tty: serial: 8250: Merge duplicate conditions Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-13 18:40 +0100
  [PATCH v5 08/15] tty: serial: 8250: Add parentheses to macro Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
  [PATCH v5 01/15] tty: serial: 8250: Fix whitespace errors Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
  [PATCH v5 04/15] tty: serial: 8250: Fix multiline comment style Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
    Re: [PATCH v5 04/15] tty: serial: 8250: Fix multiline comment style Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-13 18:10 +0100
  [PATCH v5 13/15] tty: serial: 8250: Fix indentation warnings Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
  [PATCH v5 07/15] tty: serial: 8250: Fix line continuation warning Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
  [PATCH v5 12/15] tty: serial: 8250: Correct conversion specifiers Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
  [PATCH v5 03/15] tty: serial: 8250: Fix braces after struct Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100
  [PATCH v5 02/15] tty: serial: 8250: Replace spaces with tabs Anton Wuerfel <anton.wuerfel@fau.de> - 2016-01-13 17:50 +0100

csiph-web