Re: [PATCH] netfilter: nft_ct: mark nft_ct_get_eval_counter __maybe_unused

From	Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] netfilter: nft_ct: mark nft_ct_get_eval_counter __maybe_unused
Date	2016-01-13 17:50 +0100
Message-ID	<qQwMq-2sp-5@gated-at.bofh.it> (permalink)
References	<qQuhA-Oj-23@gated-at.bofh.it> <qQw02-1PH-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 13, 2016 at 04:54:24PM +0100, Pablo Neira Ayuso wrote:
> On Wed, Jan 13, 2016 at 02:58:11PM +0100, Arnd Bergmann wrote:
> > The newly added nft_ct_get_eval_counter() function is only used when
> > CONFIG_NF_CONNTRACK_LABELS is set, otherwise gcc warns about the
> > unused definition:
> > 
> > netfilter/nft_ct.c:34:12: warning: 'nft_ct_get_eval_counter' defined but not used [-Wunused-function]
> >  static u64 nft_ct_get_eval_counter(const struct nf_conn_counter *c,
> > 
> > This marks the function __maybe_unused to shut up the warning.
> 
> It seems that function doesn't below to CONFIG_NF_CONNTRACK_LABELS as
> it is part of the new counter support. Will be sending an alternate
> patch instead.

Just for the record, I submitted this fix:

http://patchwork.ozlabs.org/patch/567063/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] netfilter: nft_ct: mark nft_ct_get_eval_counter __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-01-13 15:10 +0100
  Re: [PATCH] netfilter: nft_ct: mark nft_ct_get_eval_counter  __maybe_unused Pablo Neira Ayuso <pablo@netfilter.org> - 2016-01-13 17:00 +0100
    Re: [PATCH] netfilter: nft_ct: mark nft_ct_get_eval_counter  __maybe_unused Pablo Neira Ayuso <pablo@netfilter.org> - 2016-01-13 17:50 +0100

csiph-web